Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2446963003: Clean up logging in AudioSendStream::SetupSendCodec(). (Closed)

Created:
4 years, 1 month ago by the sun
Modified:
4 years, 1 month ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tlegrand-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Clean up logging in AudioSendStream::SetupSendCodec(). As a side effect: - Moved the AudioSendStream::Config::SendCodecSpec methods into the .cc. - Which exposed an issue with event_visualizer_utils not having a dependency on api:call_api set up. - Which further exposed clang warnings about large inlined default methods in webrtc/config.h. BUG=webrtc:4690 Committed: https://crrev.com/1836fd6257a692959b3b49ba99ef587ad9995871 Committed: https://crrev.com/940b6d648fab0e240d15fc1feb4ef45e0f418b5d Cr-Original-Commit-Position: refs/heads/master@{#14771} Cr-Commit-Position: refs/heads/master@{#14780}

Patch Set 1 #

Patch Set 2 : Another missing dep #

Patch Set 3 : remove dep that should be transitive #

Patch Set 4 : fix build breakage? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -128 lines) Patch
M webrtc/api/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/api.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/call/audio_send_stream.h View 3 chunks +9 lines, -37 lines 0 comments Download
A webrtc/api/call/audio_send_stream.cc View 1 chunk +118 lines, -0 lines 0 comments Download
M webrtc/audio/audio_send_stream.cc View 5 chunks +17 lines, -82 lines 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 1 2 3 1 chunk +16 lines, -2 lines 0 comments Download
M webrtc/config.h View 6 chunks +8 lines, -7 lines 0 comments Download
M webrtc/config.cc View 4 chunks +13 lines, -0 lines 0 comments Download
M webrtc/logging/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/webrtc.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
the sun
4 years, 1 month ago (2016-10-25 08:43:59 UTC) #2
kwiberg-webrtc
lgtm
4 years, 1 month ago (2016-10-25 13:04:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2446963003/40001
4 years, 1 month ago (2016-10-25 13:07:15 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-25 13:44:48 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/1836fd6257a692959b3b49ba99ef587ad9995871 Cr-Commit-Position: refs/heads/master@{#14771}
4 years, 1 month ago (2016-10-25 13:44:56 UTC) #8
terelius
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.webrtc.org/2452643002/ by terelius@webrtc.org. ...
4 years, 1 month ago (2016-10-25 14:56:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2446963003/60001
4 years, 1 month ago (2016-10-25 17:54:27 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-25 18:19:11 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 18:23:00 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/940b6d648fab0e240d15fc1feb4ef45e0f418b5d
Cr-Commit-Position: refs/heads/master@{#14780}

Powered by Google App Engine
This is Rietveld 408576698