Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: webrtc/config.h

Issue 2446963003: Clean up logging in AudioSendStream::SetupSendCodec(). (Closed)
Patch Set: fix build breakage? Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/audio/audio_send_stream_unittest.cc ('k') | webrtc/config.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/config.h
diff --git a/webrtc/config.h b/webrtc/config.h
index 4ec895b0dd8265b34043a75cb082575ffb29dc7f..3b3c3d90a811234515dd0348fe44da8be153ff1d 100644
--- a/webrtc/config.h
+++ b/webrtc/config.h
@@ -57,8 +57,8 @@ struct UlpfecConfig {
// Settings for FlexFEC forward error correction.
// Set the payload type to '-1' to disable.
struct FlexfecConfig {
- FlexfecConfig()
- : flexfec_payload_type(-1), flexfec_ssrc(0), protected_media_ssrcs() {}
+ FlexfecConfig();
+ ~FlexfecConfig();
std::string ToString() const;
// Payload type of FlexFEC.
@@ -163,7 +163,7 @@ class VideoEncoderConfig {
virtual void FillVideoCodecVp9(VideoCodecVP9* vp9_settings) const;
virtual void FillVideoCodecH264(VideoCodecH264* h264_settings) const;
private:
- virtual ~EncoderSpecificSettings() {}
+ ~EncoderSpecificSettings() override {}
friend class VideoEncoderConfig;
};
@@ -211,7 +211,7 @@ class VideoEncoderConfig {
const VideoEncoderConfig& encoder_config) = 0;
protected:
- virtual ~VideoStreamFactoryInterface() {}
+ ~VideoStreamFactoryInterface() override {}
};
VideoEncoderConfig& operator=(VideoEncoderConfig&&) = default;
@@ -221,7 +221,7 @@ class VideoEncoderConfig {
VideoEncoderConfig Copy() const { return VideoEncoderConfig(*this); }
VideoEncoderConfig();
- VideoEncoderConfig(VideoEncoderConfig&&) = default;
+ VideoEncoderConfig(VideoEncoderConfig&&);
~VideoEncoderConfig();
std::string ToString() const;
@@ -243,7 +243,7 @@ class VideoEncoderConfig {
private:
// Access to the copy constructor is private to force use of the Copy()
// method for those exceptional cases where we do use it.
- VideoEncoderConfig(const VideoEncoderConfig&) = default;
+ VideoEncoderConfig(const VideoEncoderConfig&);
};
struct VideoDecoderH264Settings {
@@ -252,7 +252,8 @@ struct VideoDecoderH264Settings {
class DecoderSpecificSettings {
public:
- virtual ~DecoderSpecificSettings() {}
+ DecoderSpecificSettings();
+ virtual ~DecoderSpecificSettings();
rtc::Optional<VideoDecoderH264Settings> h264_extra_settings;
};
« no previous file with comments | « webrtc/audio/audio_send_stream_unittest.cc ('k') | webrtc/config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698