Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2445933003: Fix "IsLoopbackIp" to cover all loopback addresses; not just 127.0.0.1. (Closed)

Created:
4 years, 1 month ago by Taylor Brandstetter
Modified:
4 years, 1 month ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix "IsLoopbackIp" to cover all loopback addresses; not just 127.0.0.1. The loopback range is 127.0.0.0/8, which is everything from 127.0.0.0 to 127.255.255.255. BUG=chromium:649118 Committed: https://crrev.com/9922016ee44c70eb1c14f647cc4a5ade58a0018c Cr-Commit-Position: refs/heads/master@{#14807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M webrtc/base/ipaddress.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/ipaddress_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/p2p/base/turnport_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
pthatcher1
lgtm
4 years, 1 month ago (2016-10-28 00:57:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2445933003/1
4 years, 1 month ago (2016-10-28 01:09:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 01:30:25 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 01:30:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9922016ee44c70eb1c14f647cc4a5ade58a0018c
Cr-Commit-Position: refs/heads/master@{#14807}

Powered by Google App Engine
This is Rietveld 408576698