Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Side by Side Diff: webrtc/base/ipaddress.cc

Issue 2445933003: Fix "IsLoopbackIp" to cover all loopback addresses; not just 127.0.0.1. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/base/ipaddress_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 return ip == IPAddress(in6addr_any) || ip == IPAddress(kV4MappedPrefix); 287 return ip == IPAddress(in6addr_any) || ip == IPAddress(kV4MappedPrefix);
288 case AF_UNSPEC: 288 case AF_UNSPEC:
289 return false; 289 return false;
290 } 290 }
291 return false; 291 return false;
292 } 292 }
293 293
294 bool IPIsLoopback(const IPAddress& ip) { 294 bool IPIsLoopback(const IPAddress& ip) {
295 switch (ip.family()) { 295 switch (ip.family()) {
296 case AF_INET: { 296 case AF_INET: {
297 return ip == IPAddress(INADDR_LOOPBACK); 297 return (ip.v4AddressAsHostOrderInteger() >> 24) == 127;
298 } 298 }
299 case AF_INET6: { 299 case AF_INET6: {
300 return ip == IPAddress(in6addr_loopback); 300 return ip == IPAddress(in6addr_loopback);
301 } 301 }
302 } 302 }
303 return false; 303 return false;
304 } 304 }
305 305
306 bool IPIsPrivate(const IPAddress& ip) { 306 bool IPIsPrivate(const IPAddress& ip) {
307 switch (ip.family()) { 307 switch (ip.family()) {
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
518 if (family == AF_INET) { 518 if (family == AF_INET) {
519 return rtc::IPAddress(INADDR_ANY); 519 return rtc::IPAddress(INADDR_ANY);
520 } 520 }
521 if (family == AF_INET6) { 521 if (family == AF_INET6) {
522 return rtc::IPAddress(in6addr_any); 522 return rtc::IPAddress(in6addr_any);
523 } 523 }
524 return rtc::IPAddress(); 524 return rtc::IPAddress();
525 } 525 }
526 526
527 } // namespace rtc 527 } // namespace rtc
OLDNEW
« no previous file with comments | « no previous file | webrtc/base/ipaddress_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698