Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2445373002: NetEq: Remove special case for Merge without Expand (Closed)

Created:
4 years, 1 month ago by kwiberg-webrtc
Modified:
4 years, 1 month ago
Reviewers:
ossu, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/branch-heads/55
Project:
webrtc
Visibility:
Public.

Description

NetEq: Remove special case for Merge without Expand (This is a backport of revision 14627 (c9ec8758db79c6fe4de). Original CL here: https://codereview.webrtc.org/2412883002) This was an ill tested special case which turned out to be more problem than benefit. The special case was only triggered when the decoder frame size was smaller than 10 ms, which is more or less unsupported by NetEq. Also fixed a bug in a test, a bug which was exposed by the code change. BUG=chromium:654983, chromium:653656 R=ossu@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/c64c620c83176c6766d3e150558bc866ebb7f7c5

Patch Set 1 : The original CL, not modified at all #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M webrtc/modules/audio_coding/neteq/decision_logic_normal.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/decision_logic_normal.cc View 1 chunk +1 line, -6 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
kwiberg-webrtc
I'm backporting one of Henrik's CLs to M55; see the second of the listed bugs ...
4 years, 1 month ago (2016-10-25 11:29:55 UTC) #2
ossu
lgtm
4 years, 1 month ago (2016-10-25 12:07:31 UTC) #3
kwiberg-webrtc
Committed patchset #1 (id:1) manually as c64c620c83176c6766d3e150558bc866ebb7f7c5.
4 years, 1 month ago (2016-10-25 12:10:12 UTC) #5
hlundin-webrtc
4 years, 1 month ago (2016-10-27 10:52:02 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698