Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1498)

Issue 2412883002: NetEq: Remove special case for Merge without Expand (Closed)

Created:
4 years, 2 months ago by hlundin-webrtc
Modified:
4 years, 2 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

NetEq: Remove special case for Merge without Expand This was an ill tested special case which turned out to be more problem than benefit. The special case was only triggered when the decoder frame size was smaller than 10 ms, which is more or less unsupported by NetEq. Also fixed a bug in a test, a bug which was exposed by the code change. BUG=chromium:654983 Committed: https://crrev.com/c9ec8758db79c6fe4dee42d785f681931ddd7911 Cr-Commit-Position: refs/heads/master@{#14627}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M webrtc/modules/audio_coding/neteq/decision_logic_normal.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/decision_logic_normal.cc View 1 chunk +1 line, -6 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
hlundin-webrtc
PTAL
4 years, 2 months ago (2016-10-12 13:49:38 UTC) #3
minyue-webrtc
lgtm
4 years, 2 months ago (2016-10-13 08:13:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2412883002/1
4 years, 2 months ago (2016-10-13 08:41:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_clang_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_clang_dbg/builds/6220)
4 years, 2 months ago (2016-10-13 08:49:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2412883002/1
4 years, 2 months ago (2016-10-13 09:35:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 09:43:37 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 09:43:47 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9ec8758db79c6fe4dee42d785f681931ddd7911
Cr-Commit-Position: refs/heads/master@{#14627}

Powered by Google App Engine
This is Rietveld 408576698