Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: webrtc/modules/audio_device/audio_device_impl.cc

Issue 2445363003: Improvements in how WebRTC.Audio.RecordedOnlyZeros is added as histogram (Closed)
Patch Set: Added TODO(henrika) Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/audio_device/audio_device_buffer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_device/audio_device_impl.cc
diff --git a/webrtc/modules/audio_device/audio_device_impl.cc b/webrtc/modules/audio_device/audio_device_impl.cc
index cf69275eebd5634fc8136937aaba64e1838aa8eb..80cb1be44931d1d7063b4268a511f08f20dc59f8 100644
--- a/webrtc/modules/audio_device/audio_device_impl.cc
+++ b/webrtc/modules/audio_device/audio_device_impl.cc
@@ -1346,7 +1346,6 @@ int32_t AudioDeviceModuleImpl::InitPlayout() {
if (PlayoutIsInitialized()) {
return 0;
}
- _audioDeviceBuffer.InitPlayout();
int32_t result = _ptrAudioDevice->InitPlayout();
LOG(INFO) << "output: " << result;
RTC_HISTOGRAM_BOOLEAN("WebRTC.Audio.InitPlayoutSuccess",
@@ -1364,7 +1363,6 @@ int32_t AudioDeviceModuleImpl::InitRecording() {
if (RecordingIsInitialized()) {
return 0;
}
- _audioDeviceBuffer.InitRecording();
int32_t result = _ptrAudioDevice->InitRecording();
LOG(INFO) << "output: " << result;
RTC_HISTOGRAM_BOOLEAN("WebRTC.Audio.InitRecordingSuccess",
@@ -1402,6 +1400,7 @@ int32_t AudioDeviceModuleImpl::StartPlayout() {
if (Playing()) {
return 0;
}
+ _audioDeviceBuffer.StartPlayout();
int32_t result = _ptrAudioDevice->StartPlayout();
LOG(INFO) << "output: " << result;
RTC_HISTOGRAM_BOOLEAN("WebRTC.Audio.StartPlayoutSuccess",
@@ -1417,6 +1416,7 @@ int32_t AudioDeviceModuleImpl::StopPlayout() {
LOG(INFO) << __FUNCTION__;
CHECK_INITIALIZED();
int32_t result = _ptrAudioDevice->StopPlayout();
+ _audioDeviceBuffer.StopPlayout();
LOG(INFO) << "output: " << result;
RTC_HISTOGRAM_BOOLEAN("WebRTC.Audio.StopPlayoutSuccess",
static_cast<int>(result == 0));
@@ -1443,6 +1443,7 @@ int32_t AudioDeviceModuleImpl::StartRecording() {
if (Recording()) {
return 0;
}
+ _audioDeviceBuffer.StartRecording();
int32_t result = _ptrAudioDevice->StartRecording();
LOG(INFO) << "output: " << result;
RTC_HISTOGRAM_BOOLEAN("WebRTC.Audio.StartRecordingSuccess",
@@ -1457,6 +1458,7 @@ int32_t AudioDeviceModuleImpl::StopRecording() {
LOG(INFO) << __FUNCTION__;
CHECK_INITIALIZED();
int32_t result = _ptrAudioDevice->StopRecording();
+ _audioDeviceBuffer.StopRecording();
LOG(INFO) << "output: " << result;
RTC_HISTOGRAM_BOOLEAN("WebRTC.Audio.StopRecordingSuccess",
static_cast<int>(result == 0));
« no previous file with comments | « webrtc/modules/audio_device/audio_device_buffer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698