Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2444923002: Revert of Fix some chromium style warnings in remote_bitrate_estimator.h (Closed)

Created:
4 years, 1 month ago by terelius
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Fix some chromium style warnings in remote_bitrate_estimator.h (patchset #1 id:1 of https://codereview.webrtc.org/2387113008/ ) Reason for revert: Broke internal project. Original issue's description: > Fix some chromium style warnings in remote_bitrate_estimator.h > > BUG=webrtc:163 > > Committed: https://crrev.com/c22bcf4f4bed1f05b5e59127f93b58129cd2627f > Cr-Commit-Position: refs/heads/master@{#14737} TBR=stefan@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:163 Committed: https://crrev.com/2206c959f1e319234ad658506405f1e2459a6399 Cr-Commit-Position: refs/heads/master@{#14743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
terelius
Created Revert of Fix some chromium style warnings in remote_bitrate_estimator.h
4 years, 1 month ago (2016-10-24 13:43:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2444923002/1
4 years, 1 month ago (2016-10-24 13:43:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 13:43:28 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 13:43:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2206c959f1e319234ad658506405f1e2459a6399
Cr-Commit-Position: refs/heads/master@{#14743}

Powered by Google App Engine
This is Rietveld 408576698