Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Side by Side Diff: webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h

Issue 2444923002: Revert of Fix some chromium style warnings in remote_bitrate_estimator.h (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 27 matching lines...) Expand all
38 38
39 virtual ~RemoteBitrateObserver() {} 39 virtual ~RemoteBitrateObserver() {}
40 }; 40 };
41 41
42 // TODO(holmer): Remove when all implementations have been updated. 42 // TODO(holmer): Remove when all implementations have been updated.
43 struct ReceiveBandwidthEstimatorStats {}; 43 struct ReceiveBandwidthEstimatorStats {};
44 44
45 class RemoteBitrateEstimator : public CallStatsObserver, public Module { 45 class RemoteBitrateEstimator : public CallStatsObserver, public Module {
46 public: 46 public:
47 static const int kDefaultMinBitrateBps = 30000; 47 static const int kDefaultMinBitrateBps = 30000;
48 ~RemoteBitrateEstimator() override {} 48 virtual ~RemoteBitrateEstimator() {}
49 49
50 virtual void IncomingPacketFeedbackVector( 50 virtual void IncomingPacketFeedbackVector(
51 const std::vector<PacketInfo>& packet_feedback_vector) = 0; 51 const std::vector<PacketInfo>& packet_feedback_vector) {
52 assert(false);
53 }
52 54
53 // Called for each incoming packet. Updates the incoming payload bitrate 55 // Called for each incoming packet. Updates the incoming payload bitrate
54 // estimate and the over-use detector. If an over-use is detected the 56 // estimate and the over-use detector. If an over-use is detected the
55 // remote bitrate estimate will be updated. Note that |payload_size| is the 57 // remote bitrate estimate will be updated. Note that |payload_size| is the
56 // packet size excluding headers. 58 // packet size excluding headers.
57 // Note that |arrival_time_ms| can be of an arbitrary time base. 59 // Note that |arrival_time_ms| can be of an arbitrary time base.
58 virtual void IncomingPacket(int64_t arrival_time_ms, 60 virtual void IncomingPacket(int64_t arrival_time_ms,
59 size_t payload_size, 61 size_t payload_size,
60 const RTPHeader& header) = 0; 62 const RTPHeader& header) = 0;
61 63
(...skipping 14 matching lines...) Expand all
76 virtual void SetMinBitrate(int min_bitrate_bps) = 0; 78 virtual void SetMinBitrate(int min_bitrate_bps) = 0;
77 79
78 protected: 80 protected:
79 static const int64_t kProcessIntervalMs = 500; 81 static const int64_t kProcessIntervalMs = 500;
80 static const int64_t kStreamTimeOutMs = 2000; 82 static const int64_t kStreamTimeOutMs = 2000;
81 }; 83 };
82 84
83 } // namespace webrtc 85 } // namespace webrtc
84 86
85 #endif // WEBRTC_MODULES_REMOTE_BITRATE_ESTIMATOR_INCLUDE_REMOTE_BITRATE_ESTIMA TOR_H_ 87 #endif // WEBRTC_MODULES_REMOTE_BITRATE_ESTIMATOR_INCLUDE_REMOTE_BITRATE_ESTIMA TOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698