Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2443693003: Add parsing support for display: contents, and minimum behavior similar to display: none (Closed)

Created:
4 years, 2 months ago by emilio
Modified:
4 years, 1 month ago
Reviewers:
Manuel Rego, dgozman, eae, rune, drott
CC:
chromium-reviews, devtools-reviews_chromium.org, caseq+blink_chromium.org, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, blink-reviews-css, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, blink-reviews, kozyatinskiy+blink_chromium.org, blink-reviews-layout_chromium.org, pfeldman, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add parsing support for display: contents, and minimum behavior similar to display: none The following commit adds parsing for the display: contents value, gated after a runtime enabled feature, and adds the basic code for display: contents elements to not generate a LayoutObject. BUG=657748 TEST=LayoutTests/css-display-3/display-contents-set-get.html Committed: https://crrev.com/310aa236042e11fc39958ab02e9ff55b393fced8 Cr-Commit-Position: refs/heads/master@{#427437}

Patch Set 1 #

Patch Set 2 : Add parsing support for display: contents, and minimum behavior similar to display: none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -16 lines) Patch
A third_party/WebKit/LayoutTests/css-display-3/display-contents-set-get.html View 1 chunk +43 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/csswg-test/css-display-3/display-contents-computed-style-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/autocomplete-css-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueKeywords.in View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
Manuel Rego
LGTM as this was already reviewed in: https://codereview.chromium.org/2439503002/ But we need an OWNER for platform/ ...
4 years, 2 months ago (2016-10-24 08:06:03 UTC) #6
Manuel Rego
@emilio you've to update the test results for inspector/sources/autocomplete-css.html And also update the expectations for ...
4 years, 1 month ago (2016-10-24 10:29:51 UTC) #7
emilio
On 2016/10/24 10:29:51, Manuel Rego wrote: > @emilio you've to update the test results for ...
4 years, 1 month ago (2016-10-25 10:16:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443693003/20001
4 years, 1 month ago (2016-10-25 10:22:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443693003/20001
4 years, 1 month ago (2016-10-25 10:23:18 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/288616)
4 years, 1 month ago (2016-10-25 10:29:47 UTC) #16
Manuel Rego
We need LGTMs for platform/ and devtools/ yet. Adding owners of these folders as reviewers, ...
4 years, 1 month ago (2016-10-25 10:35:50 UTC) #18
drott
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in LGTM
4 years, 1 month ago (2016-10-25 13:59:24 UTC) #19
dgozman
devtools lgtm
4 years, 1 month ago (2016-10-25 17:37:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443693003/20001
4 years, 1 month ago (2016-10-25 17:49:06 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-25 19:19:48 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 19:35:54 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/310aa236042e11fc39958ab02e9ff55b393fced8
Cr-Commit-Position: refs/heads/master@{#427437}

Powered by Google App Engine
This is Rietveld 408576698