Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 2443163002: rtcstats_objects.h updated with TODOs about stats not being collected (Closed)

Created:
4 years, 2 months ago by hbos
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

rtcstats_objects.h updated with TODOs about stats not being collected or not being collected correctly. These TODOs are already documented and in greater detail in rtcstatscollector.cc, but if every discrepency is listed in rtcstats_objects.h it is easier to get an overview of the progress of the new GetStats API. BUG=chromium:627816 TBR=hta@webrtc.org NOTRY=True Committed: https://crrev.com/5d79a7cb1f74673daf827e38ec3778c727b4b400 Cr-Commit-Position: refs/heads/master@{#14749}

Patch Set 1 #

Patch Set 2 : Removed duplicate information TODOs, kept TODOs with additional info #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -23 lines) Patch
M webrtc/api/rtcstatscollector.cc View 1 3 chunks +0 lines, -21 lines 0 comments Download
M webrtc/api/rtcstatscollector_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/stats/rtcstats_objects.h View 3 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 28 (19 generated)
hbos_chromium
Please take a look, hta
4 years, 2 months ago (2016-10-24 12:02:34 UTC) #7
hta - Chromium
lgtm consider removing TODOs in other places that have no more information than what's here; ...
4 years, 1 month ago (2016-10-24 12:36:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2443163002/1
4 years, 1 month ago (2016-10-24 13:39:11 UTC) #12
hbos_chromium
On 2016/10/24 12:36:00, hta - Chromium wrote: > lgtm > > consider removing TODOs in ...
4 years, 1 month ago (2016-10-24 13:40:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2443163002/20001
4 years, 1 month ago (2016-10-24 13:46:21 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on ...
4 years, 1 month ago (2016-10-24 15:46:44 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2443163002/20001
4 years, 1 month ago (2016-10-24 16:24:58 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-24 16:27:13 UTC) #26
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 16:50:07 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d79a7cb1f74673daf827e38ec3778c727b4b400
Cr-Commit-Position: refs/heads/master@{#14749}

Powered by Google App Engine
This is Rietveld 408576698