|
|
Descriptionrtcstats_objects.h updated with TODOs about stats not being collected
or not being collected correctly.
These TODOs are already documented and in greater detail in
rtcstatscollector.cc, but if every discrepency is listed in
rtcstats_objects.h it is easier to get an overview of the progress of
the new GetStats API.
BUG=chromium:627816
TBR=hta@webrtc.org
NOTRY=True
Committed: https://crrev.com/5d79a7cb1f74673daf827e38ec3778c727b4b400
Cr-Commit-Position: refs/heads/master@{#14749}
Patch Set 1 #Patch Set 2 : Removed duplicate information TODOs, kept TODOs with additional info #
Messages
Total messages: 28 (19 generated)
Description was changed from ========== rtcstats_objects.h updated with TODOs about stats not being collected or not being collected correctly. These TODOs are already documented and in greater detail in rtcstatscollector.cc, but if every discrepency is listed in rtcstats_objects.h it is easier to get an overview of the progress of the new GetStats API. BUG=chromium:627816 ========== to ========== rtcstats_objects.h updated with TODOs about stats not being collected or not being collected correctly. These TODOs are already documented and in greater detail in rtcstatscollector.cc, but if every discrepency is listed in rtcstats_objects.h it is easier to get an overview of the progress of the new GetStats API. BUG=chromium:627816 ==========
hbos@chromium.org changed reviewers: + hta@webrtc.org
The CQ bit was checked by hbos@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
Please take a look, hta
hta@chromium.org changed reviewers: + hta@chromium.org
lgtm consider removing TODOs in other places that have no more information than what's here; if this is the collected list, then this should be the only list we should need to update unless details are more easily understood for a TODO elsewhere.
Description was changed from ========== rtcstats_objects.h updated with TODOs about stats not being collected or not being collected correctly. These TODOs are already documented and in greater detail in rtcstatscollector.cc, but if every discrepency is listed in rtcstats_objects.h it is easier to get an overview of the progress of the new GetStats API. BUG=chromium:627816 ========== to ========== rtcstats_objects.h updated with TODOs about stats not being collected or not being collected correctly. These TODOs are already documented and in greater detail in rtcstatscollector.cc, but if every discrepency is listed in rtcstats_objects.h it is easier to get an overview of the progress of the new GetStats API. BUG=chromium:627816 TBR=hta@webrtc.org ==========
The CQ bit was checked by hbos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by hbos@chromium.org
Description was changed from ========== rtcstats_objects.h updated with TODOs about stats not being collected or not being collected correctly. These TODOs are already documented and in greater detail in rtcstatscollector.cc, but if every discrepency is listed in rtcstats_objects.h it is easier to get an overview of the progress of the new GetStats API. BUG=chromium:627816 TBR=hta@webrtc.org ========== to ========== rtcstats_objects.h updated with TODOs about stats not being collected or not being collected correctly. These TODOs are already documented and in greater detail in rtcstatscollector.cc, but if every discrepency is listed in rtcstats_objects.h it is easier to get an overview of the progress of the new GetStats API. BUG=chromium:627816 ==========
On 2016/10/24 12:36:00, hta - Chromium wrote: > lgtm > > consider removing TODOs in other places that have no more information than > what's here; if this is the collected list, then this should be the only list we > should need to update unless details are more easily understood for a TODO > elsewhere. I'll do that before landing. You lgtm'd with your @chromium, not your @webrtc.
Description was changed from ========== rtcstats_objects.h updated with TODOs about stats not being collected or not being collected correctly. These TODOs are already documented and in greater detail in rtcstatscollector.cc, but if every discrepency is listed in rtcstats_objects.h it is easier to get an overview of the progress of the new GetStats API. BUG=chromium:627816 ========== to ========== rtcstats_objects.h updated with TODOs about stats not being collected or not being collected correctly. These TODOs are already documented and in greater detail in rtcstatscollector.cc, but if every discrepency is listed in rtcstats_objects.h it is easier to get an overview of the progress of the new GetStats API. BUG=chromium:627816 TBR=hta@webrtc.org ==========
The CQ bit was checked by hbos@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hta@chromium.org, hbos@chromium.org Link to the patchset: https://codereview.chromium.org/2443163002/#ps20001 (title: "Removed duplicate information TODOs, kept TODOs with additional info")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_mips_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x64_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x86_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_x86_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_arm on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_asan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_compile_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_libfuzzer_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_msan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_tsan2 on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_ubsan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_ubsan_vptr on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Description was changed from ========== rtcstats_objects.h updated with TODOs about stats not being collected or not being collected correctly. These TODOs are already documented and in greater detail in rtcstatscollector.cc, but if every discrepency is listed in rtcstats_objects.h it is easier to get an overview of the progress of the new GetStats API. BUG=chromium:627816 TBR=hta@webrtc.org ========== to ========== rtcstats_objects.h updated with TODOs about stats not being collected or not being collected correctly. These TODOs are already documented and in greater detail in rtcstatscollector.cc, but if every discrepency is listed in rtcstats_objects.h it is easier to get an overview of the progress of the new GetStats API. BUG=chromium:627816 TBR=hta@webrtc.org NOTRY=True ==========
The CQ bit was checked by hbos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== rtcstats_objects.h updated with TODOs about stats not being collected or not being collected correctly. These TODOs are already documented and in greater detail in rtcstatscollector.cc, but if every discrepency is listed in rtcstats_objects.h it is easier to get an overview of the progress of the new GetStats API. BUG=chromium:627816 TBR=hta@webrtc.org NOTRY=True ========== to ========== rtcstats_objects.h updated with TODOs about stats not being collected or not being collected correctly. These TODOs are already documented and in greater detail in rtcstatscollector.cc, but if every discrepency is listed in rtcstats_objects.h it is easier to get an overview of the progress of the new GetStats API. BUG=chromium:627816 TBR=hta@webrtc.org NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== rtcstats_objects.h updated with TODOs about stats not being collected or not being collected correctly. These TODOs are already documented and in greater detail in rtcstatscollector.cc, but if every discrepency is listed in rtcstats_objects.h it is easier to get an overview of the progress of the new GetStats API. BUG=chromium:627816 TBR=hta@webrtc.org NOTRY=True ========== to ========== rtcstats_objects.h updated with TODOs about stats not being collected or not being collected correctly. These TODOs are already documented and in greater detail in rtcstatscollector.cc, but if every discrepency is listed in rtcstats_objects.h it is easier to get an overview of the progress of the new GetStats API. BUG=chromium:627816 TBR=hta@webrtc.org NOTRY=True Committed: https://crrev.com/5d79a7cb1f74673daf827e38ec3778c727b4b400 Cr-Commit-Position: refs/heads/master@{#14749} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5d79a7cb1f74673daf827e38ec3778c727b4b400 Cr-Commit-Position: refs/heads/master@{#14749} |