Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Side by Side Diff: webrtc/api/rtcstatscollector_unittest.cc

Issue 2443163002: rtcstats_objects.h updated with TODOs about stats not being collected (Closed)
Patch Set: Removed duplicate information TODOs, kept TODOs with additional info Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/rtcstatscollector.cc ('k') | webrtc/api/stats/rtcstats_objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 357 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 channel_stats.connection_infos) { 368 channel_stats.connection_infos) {
369 const std::string& id = "RTCIceCandidatePair_" + 369 const std::string& id = "RTCIceCandidatePair_" +
370 info.local_candidate.id() + "_" + info.remote_candidate.id(); 370 info.local_candidate.id() + "_" + info.remote_candidate.id();
371 const RTCStats* stats = report->Get(id); 371 const RTCStats* stats = report->Get(id);
372 ASSERT_TRUE(stats); 372 ASSERT_TRUE(stats);
373 const RTCIceCandidatePairStats& candidate_pair_stats = 373 const RTCIceCandidatePairStats& candidate_pair_stats =
374 stats->cast_to<RTCIceCandidatePairStats>(); 374 stats->cast_to<RTCIceCandidatePairStats>();
375 375
376 // TODO(hbos): Define all the undefined |candidate_pair_stats| stats. 376 // TODO(hbos): Define all the undefined |candidate_pair_stats| stats.
377 // The EXPECT_FALSE are for the undefined stats, see also todos listed 377 // The EXPECT_FALSE are for the undefined stats, see also todos listed
378 // in rtcstatscollector.cc. crbug.com/633550 378 // in rtcstats_objects.h. crbug.com/633550
379 EXPECT_FALSE(candidate_pair_stats.transport_id.is_defined()); 379 EXPECT_FALSE(candidate_pair_stats.transport_id.is_defined());
380 const RTCIceCandidateStats* local_candidate = 380 const RTCIceCandidateStats* local_candidate =
381 ExpectReportContainsCandidate(report, info.local_candidate, true); 381 ExpectReportContainsCandidate(report, info.local_candidate, true);
382 EXPECT_EQ(*candidate_pair_stats.local_candidate_id, 382 EXPECT_EQ(*candidate_pair_stats.local_candidate_id,
383 local_candidate->id()); 383 local_candidate->id());
384 const RTCIceCandidateStats* remote_candidate = 384 const RTCIceCandidateStats* remote_candidate =
385 ExpectReportContainsCandidate(report, info.remote_candidate, false); 385 ExpectReportContainsCandidate(report, info.remote_candidate, false);
386 EXPECT_EQ(*candidate_pair_stats.remote_candidate_id, 386 EXPECT_EQ(*candidate_pair_stats.remote_candidate_id,
387 remote_candidate->id()); 387 remote_candidate->id());
388 388
(...skipping 653 matching lines...) Expand 10 before | Expand all | Expand 10 after
1042 rtc::scoped_refptr<FakeRTCStatsCollector> collector_; 1042 rtc::scoped_refptr<FakeRTCStatsCollector> collector_;
1043 }; 1043 };
1044 1044
1045 TEST_F(RTCStatsCollectorTestWithFakeCollector, ThreadUsageAndResultsMerging) { 1045 TEST_F(RTCStatsCollectorTestWithFakeCollector, ThreadUsageAndResultsMerging) {
1046 collector_->VerifyThreadUsageAndResultsMerging(); 1046 collector_->VerifyThreadUsageAndResultsMerging();
1047 } 1047 }
1048 1048
1049 } // namespace 1049 } // namespace
1050 1050
1051 } // namespace webrtc 1051 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/api/rtcstatscollector.cc ('k') | webrtc/api/stats/rtcstats_objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698