Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2428)

Unified Diff: webrtc/video_frame.h

Issue 2443123002: Delete ShallowCopy, in favor of copy construction and assignment. (Closed)
Patch Set: Rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/vie_encoder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video_frame.h
diff --git a/webrtc/video_frame.h b/webrtc/video_frame.h
index ff120a6f4c2a1515434023713de598cae5dec3d1..05692788972e4cd07c5b2fb43a1c8a802690f3b5 100644
--- a/webrtc/video_frame.h
+++ b/webrtc/video_frame.h
@@ -44,12 +44,11 @@ class VideoFrame {
int64_t render_time_ms,
VideoRotation rotation);
- // Creates a shallow copy of |videoFrame|, i.e, the this object will retain a
- // reference to the video buffer also retained by |videoFrame|.
- // TODO(nisse): Deprecated. Should be deleted in the cricket::VideoFrame and
- // webrtc::VideoFrame merge. Instead, pass video_frame_buffer() and timestamps
- // to the constructor.
- void ShallowCopy(const VideoFrame& videoFrame);
+ // Support move and copy.
+ VideoFrame(const VideoFrame&) = default;
+ VideoFrame(VideoFrame&&) = default;
+ VideoFrame& operator=(const VideoFrame&) = default;
+ VideoFrame& operator=(VideoFrame&&) = default;
// Get frame width.
int width() const;
« no previous file with comments | « webrtc/video/vie_encoder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698