webrtc/video/vie_encoder.cc - Issue 2443123002: Delete ShallowCopy, in favor of copy construction and assignment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/video/vie_encoder.cc

Issue 2443123002: Delete ShallowCopy, in favor of copy construction and assignment. (Closed)

Patch Set: Rebase. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/video/vie_encoder.cc

diff --git a/webrtc/video/vie_encoder.cc b/webrtc/video/vie_encoder.cc

index d09e40b1c36654f3329934384e1859eacc27481c..e1cd40dc98bbe2bd20ef24a2d93965fe22af661f 100644

--- a/webrtc/video/vie_encoder.cc

+++ b/webrtc/video/vie_encoder.cc

@@ -218,7 +218,7 @@ class ViEEncoder::EncodeTask : public rtc::QueuedTask {

: vie_encoder_(vie_encoder),

time_when_posted_ms_(time_when_posted_in_ms),

log_stats_(log_stats) {

- frame_.ShallowCopy(frame);

+ frame_ = frame;

++vie_encoder_->posted_frames_waiting_for_encode_;

}

« no previous file with comments | « webrtc/video/video_quality_test.cc ('k') | webrtc/video_frame.h » ('j') | no next file with comments »