Fix compile error for non Intel platforms

Fix compile error for non Intel platforms

Fixing compile error for non Intel platforms
when using C implemented fft functions
(for example, optimizations are not implemented for mips64el
and C functions must be used)

Adding bypass of presubmit to avoid code style and header
errors caused by the fact that files with legacy code are
being renamed.

NOPRESUBMIT=true
BUG=webrtc:6595
TEST=gn gen out-gn/mips64-android-webrtc --args="is_debug=false target_os=\"android\" target_cpu=\"mips64el\""
     ninja -C out-gn/mips64-android-webrtc audio_processing

Committed: https://crrev.com/11f72b1945871b79f871c570a8df965a89d7f536
Cr-Commit-Position: refs/heads/master@{#14808}

[gordanac, 2016-10-21 14:10:24]

Description was changed from

==========
Fix compile error for non Intel platforms

Fixing compile error for non Intel platforms
when using C implemented fft functions
(for example, optimizations are not implemented for mips64el
and C functions must be used)

BUG="ooura_fft.cc:353:22: error: 'cft1st_128_SSE2' was not declared in this
scope"
TEST=gn gen out-gn/mips64-android-webrtc --args="is_debug=false
target_os=\"android\" target_cpu=\"mips64el\""
     ninja -C out-gn/mips64-android-webrtc audio_processing
==========

to

==========
Fix compile error for non Intel platforms

Fixing compile error for non Intel platforms
when using C implemented fft functions
(for example, optimizations are not implemented for mips64el
and C functions must be used)

BUG="ooura_fft.cc:353:22: error: 'cft1st_128_SSE2' was not declared in this
scope"
TEST=gn gen out-gn/mips64-android-webrtc --args="is_debug=false
target_os=\"android\" target_cpu=\"mips64el\""
     ninja -C out-gn/mips64-android-webrtc audio_processing
==========

[gordanac, 2016-10-21 14:10:24]

gordana.cmiljanovic@imgtec.com changed reviewers:
+ henrik.lundin@webrtc.org, peah@webrtc.org

[gordanac, 2016-10-21 14:11:57]

Please take a look.

The compile error is introduced with
https://codereview.webrtc.org/2348213002

[hlundin-webrtc, 2016-10-24 00:57:19]

henrik.lundin@webrtc.org changed reviewers:
- henrik.lundin@webrtc.org

[peah-webrtc, 2016-10-24 05:11:15]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 05:11:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-24 05:26:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 05:26:51]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9445)

[peah-webrtc, 2016-10-24 11:04:16]

Great find! Thanks for providing the CL for this!!!

I think the CL looks great but one thing needs to be addressed.
Could you please file an issue for this and link this CL to that issue?

(The instructions for that are available on https://webrtc.org/contributing/.)

[gordanac, 2016-10-24 12:02:22]

Description was changed from

==========
Fix compile error for non Intel platforms

Fixing compile error for non Intel platforms
when using C implemented fft functions
(for example, optimizations are not implemented for mips64el
and C functions must be used)

BUG="ooura_fft.cc:353:22: error: 'cft1st_128_SSE2' was not declared in this
scope"
TEST=gn gen out-gn/mips64-android-webrtc --args="is_debug=false
target_os=\"android\" target_cpu=\"mips64el\""
     ninja -C out-gn/mips64-android-webrtc audio_processing
==========

to

==========
Fix compile error for non Intel platforms

Fixing compile error for non Intel platforms
when using C implemented fft functions
(for example, optimizations are not implemented for mips64el
and C functions must be used)

BUG=webrtc:6595
TEST=gn gen out-gn/mips64-android-webrtc --args="is_debug=false
target_os=\"android\" target_cpu=\"mips64el\""
     ninja -C out-gn/mips64-android-webrtc audio_processing
==========

[gordanac, 2016-10-24 12:09:10]

On 2016/10/24 11:04:16, peah-webrtc wrote:
> Great find! Thanks for providing the CL for this!!!
> 
> I think the CL looks great but one thing needs to be addressed.
> Could you please file an issue for this and link this CL to that issue?
> 
> (The instructions for that are available on https://webrtc.org/contributing/.)

Done.

What can I do about presubmit warning/error?

[peah-webrtc, 2016-10-27 14:15:56]

On 2016/10/24 12:09:10, gordanac wrote:
> On 2016/10/24 11:04:16, peah-webrtc wrote:
> > Great find! Thanks for providing the CL for this!!!
> > 
> > I think the CL looks great but one thing needs to be addressed.
> > Could you please file an issue for this and link this CL to that issue?
> > 
> > (The instructions for that are available on
https://webrtc.org/contributing/.)
> 
> Done.
> 
> What can I do about presubmit warning/error?

Great! Thanks!

lgtm

[peah-webrtc, 2016-10-27 14:31:12]

On 2016/10/27 14:15:56, peah-webrtc wrote:
> On 2016/10/24 12:09:10, gordanac wrote:
> > On 2016/10/24 11:04:16, peah-webrtc wrote:
> > > Great find! Thanks for providing the CL for this!!!
> > > 
> > > I think the CL looks great but one thing needs to be addressed.
> > > Could you please file an issue for this and link this CL to that issue?
> > > 
> > > (The instructions for that are available on
> https://webrtc.org/contributing/.)
> > 
> > Done.
> > 
> > What can I do about presubmit warning/error?
> 
> Great! Thanks!
> 
> lgtm

 The presubmit message should be fine, I think, since it seem to relate to the
header of the file which is not part of the code which is changed in this CL.

I'll try to land this CL now. Thanks for this important contribution!

[peah-webrtc, 2016-10-27 14:31:22]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2016-10-27 14:31:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-27 14:33:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 14:33:45]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9606)

[peah-webrtc, 2016-10-28 06:30:30]

Description was changed from

==========
Fix compile error for non Intel platforms

Fixing compile error for non Intel platforms
when using C implemented fft functions
(for example, optimizations are not implemented for mips64el
and C functions must be used)

BUG=webrtc:6595
TEST=gn gen out-gn/mips64-android-webrtc --args="is_debug=false
target_os=\"android\" target_cpu=\"mips64el\""
     ninja -C out-gn/mips64-android-webrtc audio_processing
==========

to

==========
Fix compile error for non Intel platforms

Fixing compile error for non Intel platforms
when using C implemented fft functions
(for example, optimizations are not implemented for mips64el
and C functions must be used)

Adding bypass of presubmit to avoid code style and header
errors caused by the fact that files with legacy code are
being renamed.

NOPRESUBMIT=true
BUG=webrtc:6595
TEST=gn gen out-gn/mips64-android-webrtc --args="is_debug=false
target_os=\"android\" target_cpu=\"mips64el\""
     ninja -C out-gn/mips64-android-webrtc audio_processing
==========

[peah-webrtc, 2016-10-28 06:30:53]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2016-10-28 06:31:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-28 06:44:12]

Description was changed from

==========
Fix compile error for non Intel platforms

Fixing compile error for non Intel platforms
when using C implemented fft functions
(for example, optimizations are not implemented for mips64el
and C functions must be used)

Adding bypass of presubmit to avoid code style and header
errors caused by the fact that files with legacy code are
being renamed.

NOPRESUBMIT=true
BUG=webrtc:6595
TEST=gn gen out-gn/mips64-android-webrtc --args="is_debug=false
target_os=\"android\" target_cpu=\"mips64el\""
     ninja -C out-gn/mips64-android-webrtc audio_processing
==========

to

==========
Fix compile error for non Intel platforms

Fixing compile error for non Intel platforms
when using C implemented fft functions
(for example, optimizations are not implemented for mips64el
and C functions must be used)

Adding bypass of presubmit to avoid code style and header
errors caused by the fact that files with legacy code are
being renamed.

NOPRESUBMIT=true
BUG=webrtc:6595
TEST=gn gen out-gn/mips64-android-webrtc --args="is_debug=false
target_os=\"android\" target_cpu=\"mips64el\""
     ninja -C out-gn/mips64-android-webrtc audio_processing
==========

[commit-bot: I haz the power, 2016-10-28 06:44:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-28 06:44:19]

Description was changed from

==========
Fix compile error for non Intel platforms

Fixing compile error for non Intel platforms
when using C implemented fft functions
(for example, optimizations are not implemented for mips64el
and C functions must be used)

Adding bypass of presubmit to avoid code style and header
errors caused by the fact that files with legacy code are
being renamed.

NOPRESUBMIT=true
BUG=webrtc:6595
TEST=gn gen out-gn/mips64-android-webrtc --args="is_debug=false
target_os=\"android\" target_cpu=\"mips64el\""
     ninja -C out-gn/mips64-android-webrtc audio_processing
==========

to

==========
Fix compile error for non Intel platforms

Fixing compile error for non Intel platforms
when using C implemented fft functions
(for example, optimizations are not implemented for mips64el
and C functions must be used)

Adding bypass of presubmit to avoid code style and header
errors caused by the fact that files with legacy code are
being renamed.

NOPRESUBMIT=true
BUG=webrtc:6595
TEST=gn gen out-gn/mips64-android-webrtc --args="is_debug=false
target_os=\"android\" target_cpu=\"mips64el\""
     ninja -C out-gn/mips64-android-webrtc audio_processing

Committed: https://crrev.com/11f72b1945871b79f871c570a8df965a89d7f536
Cr-Commit-Position: refs/heads/master@{#14808}
==========

[commit-bot: I haz the power, 2016-10-28 06:44:20]

Patchset 1 (id:??) landed as
https://crrev.com/11f72b1945871b79f871c570a8df965a89d7f536
Cr-Commit-Position: refs/heads/master@{#14808}

[gordanac, 2016-10-28 12:04:42]

Thank you for landing it.

When can roll into Chromium be expected?

[peah-webrtc, 2016-11-06 21:22:51]

On 2016/10/28 12:04:42, gordanac wrote:
> Thank you for landing it.
> 
> When can roll into Chromium be expected?

Sorry for the late reply! It has now landed in Chromium as well.