Move the aec_rdft* files to a more proper place beneath APM and make them thread-safe.

The FFT functionality in aec_rdft* is based on legacy C
code which is not thread-safe in the sense that the
rdft_init method can only be run in a single-threaded.

Currently, inside WebRTC multiple instances of the audio-
processing module are set up which means that the init
method may be run concurrently.

In order to avoid having to protect the init method with
a lock to ensure single-threaded behavior that, this CL
places the FFT functionality inside a class so that there
is no global component of the FFT functionality.

Note that:
1) The nonstandard header for the ooura_fft.cc was copied
   from the aec_rdft.cc header, and augmented with a
   description of the changes introduced in this CL.
2) The clang warnings for the ooura_fft_sse2.cc,
   ooura_fft_neon.cc and ooura_fft_mips.cc were not
   addressed as this code was kept as it was before this CL
3) Clang-format was run on all files apart from
   ooura_fft_mips.cc (as that would change the format of
   the inline assempbly code).

Adding bypass of presubmit to avoid code style and header errors caused by the fact that files with legacy code are being renamed.

NOPRESUBMIT=true

BUG=chromium:638583
Committed: https://crrev.com/81b9291dfddbfe1bd940ac7aab9a1b41c2b9c188
Cr-Commit-Position: refs/heads/master@{#14554}

[peah-webrtc, 2016-09-19 10:39:36]

Patchset #4 (id:60001) has been deleted

[peah-webrtc, 2016-09-19 10:39:43]

Patchset #3 (id:40001) has been deleted

[peah-webrtc, 2016-09-20 12:12:35]

Description was changed from

==========
Move the aec_rdft* files to a more proper place beneath APM and make them
thread-safe.

Moved the rdft-files to the utility folder.

BUG=chromium:638583
==========

to

==========
The FFT functionality in aec_rdft* is based on legacy C code which is not
thread-safe in the sense that the 
rdft_init method can only be run in a single-threaded.

Currently, inside WebRTC multiple instances of the audio-
processing module are set up which means that the init
method may be run concurrently.

In order to avoid having to protect the init method with
a lock to ensure single-threaded behavior that, this CL
places the FFT functionality inside a class so that there
is no global component of the FFT functionality.

Note that:
1) The nonstandard header for the ooura_fft.cc was copied 
   from the aec_rdft.cc header, and augmented with a 
   description of the changes introduced in this CL.
2) The clang warnings for the ooura_fft_sse2.cc, 
   ooura_fft_neon.cc and ooura_fft_mips.cc were not 
   addressed as this code was kept as it was before this CL
3) Clang-format was run on all files apart from 
   ooura_fft_mips.cc (as that would change the format of
   the inline assempbly code).


BUG=chromium:638583
==========

[peah-webrtc, 2016-09-20 12:16:13]

Patchset #1 (id:1) has been deleted

[peah-webrtc, 2016-09-20 12:16:20]

Patchset #1 (id:20001) has been deleted

[peah-webrtc, 2016-09-20 12:16:31]

Patchset #1 (id:80001) has been deleted

[peah-webrtc, 2016-09-20 12:16:39]

Patchset #1 (id:100001) has been deleted

[peah-webrtc, 2016-09-20 12:25:58]

Patchset #1 (id:120001) has been deleted

[peah-webrtc, 2016-09-21 08:24:23]

peah@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[peah-webrtc, 2016-09-21 08:24:41]

Patchset #1 (id:140001) has been deleted

[peah-webrtc, 2016-09-21 08:24:51]

Patchset #1 (id:160001) has been deleted

[peah-webrtc, 2016-09-21 08:25:00]

Patchset #1 (id:180001) has been deleted

[peah-webrtc, 2016-09-21 08:25:08]

Patchset #1 (id:200001) has been deleted

[peah-webrtc, 2016-09-21 08:25:16]

Patchset #1 (id:220001) has been deleted

[peah-webrtc, 2016-09-21 08:25:24]

Patchset #1 (id:240001) has been deleted

[peah-webrtc, 2016-09-21 08:25:34]

Patchset #1 (id:260001) has been deleted

[peah-webrtc, 2016-09-21 08:25:59]

Description was changed from

==========
The FFT functionality in aec_rdft* is based on legacy C code which is not
thread-safe in the sense that the 
rdft_init method can only be run in a single-threaded.

Currently, inside WebRTC multiple instances of the audio-
processing module are set up which means that the init
method may be run concurrently.

In order to avoid having to protect the init method with
a lock to ensure single-threaded behavior that, this CL
places the FFT functionality inside a class so that there
is no global component of the FFT functionality.

Note that:
1) The nonstandard header for the ooura_fft.cc was copied 
   from the aec_rdft.cc header, and augmented with a 
   description of the changes introduced in this CL.
2) The clang warnings for the ooura_fft_sse2.cc, 
   ooura_fft_neon.cc and ooura_fft_mips.cc were not 
   addressed as this code was kept as it was before this CL
3) Clang-format was run on all files apart from 
   ooura_fft_mips.cc (as that would change the format of
   the inline assempbly code).


BUG=chromium:638583
==========

to

==========
The FFT functionality in aec_rdft* is based on legacy C
code which is not thread-safe in the sense that the 
rdft_init method can only be run in a single-threaded.

Currently, inside WebRTC multiple instances of the audio-
processing module are set up which means that the init
method may be run concurrently.

In order to avoid having to protect the init method with
a lock to ensure single-threaded behavior that, this CL
places the FFT functionality inside a class so that there
is no global component of the FFT functionality.

Note that:
1) The nonstandard header for the ooura_fft.cc was copied 
   from the aec_rdft.cc header, and augmented with a 
   description of the changes introduced in this CL.
2) The clang warnings for the ooura_fft_sse2.cc, 
   ooura_fft_neon.cc and ooura_fft_mips.cc were not 
   addressed as this code was kept as it was before this CL
3) Clang-format was run on all files apart from 
   ooura_fft_mips.cc (as that would change the format of
   the inline assempbly code).


BUG=chromium:638583
==========

[hlundin-webrtc, 2016-10-05 12:54:54]

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
File webrtc/modules/audio_processing/aec/aec_core.cc (right):

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
webrtc/modules/audio_processing/aec/aec_core.cc:33: #include
"webrtc/modules/audio_processing/utility/ooura_fft.h"
No need to include here, when you already included it in aec_core.h

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
webrtc/modules/audio_processing/aec/aec_core.cc:340: const OouraFft* ooura_fft,
Why not a const ref? (This is C++ now, right?) Here and other places.

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
File webrtc/modules/audio_processing/aec/aec_core.h (right):

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
webrtc/modules/audio_processing/aec/aec_core.h:29: #include
"webrtc/modules/audio_processing//utility/ooura_fft.h"
Double //

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
File webrtc/modules/audio_processing/utility/ooura_fft.h (right):

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
webrtc/modules/audio_processing/utility/ooura_fft.h:2: *  Copyright (c) 2011 The
WebRTC project authors. All Rights Reserved.
Is this new or old? Should it be 2011 or 2016?

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
File webrtc/modules/audio_processing/utility/ooura_fft_mips.cc (right):

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
webrtc/modules/audio_processing/utility/ooura_fft_mips.cc:11: #include
"webrtc/modules/audio_processing//utility/ooura_fft.h"
Double //

[peah-webrtc, 2016-10-06 06:23:40]

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
File webrtc/modules/audio_processing/aec/aec_core.cc (right):

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
webrtc/modules/audio_processing/aec/aec_core.cc:33: #include
"webrtc/modules/audio_processing/utility/ooura_fft.h"
On 2016/10/05 12:54:53, hlundin-webrtc wrote:
> No need to include here, when you already included it in aec_core.h

Done.

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
webrtc/modules/audio_processing/aec/aec_core.cc:340: const OouraFft* ooura_fft,
On 2016/10/05 12:54:53, hlundin-webrtc wrote:
> Why not a const ref? (This is C++ now, right?) Here and other places.

Good point!
Done.

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
File webrtc/modules/audio_processing/aec/aec_core.h (right):

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
webrtc/modules/audio_processing/aec/aec_core.h:29: #include
"webrtc/modules/audio_processing//utility/ooura_fft.h"
On 2016/10/05 12:54:53, hlundin-webrtc wrote:
> Double //

Done.

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
File webrtc/modules/audio_processing/utility/ooura_fft.h (right):

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
webrtc/modules/audio_processing/utility/ooura_fft.h:2: *  Copyright (c) 2011 The
WebRTC project authors. All Rights Reserved.
On 2016/10/05 12:54:53, hlundin-webrtc wrote:
> Is this new or old? Should it be 2011 or 2016?

This is basically what remained when the former include file was edited. It is
actually the former renamed include file, but since it is almost totally changed
I think a data change should be motivated. I'll change that. Please let me know,
though, if you think otherwise.

Done.

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
File webrtc/modules/audio_processing/utility/ooura_fft_mips.cc (right):

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
webrtc/modules/audio_processing/utility/ooura_fft_mips.cc:11: #include
"webrtc/modules/audio_processing//utility/ooura_fft.h"
On 2016/10/05 12:54:53, hlundin-webrtc wrote:
> Double //

Done.

[hlundin-webrtc, 2016-10-06 08:48:44]

lgtm

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
File webrtc/modules/audio_processing/utility/ooura_fft.h (right):

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
webrtc/modules/audio_processing/utility/ooura_fft.h:2: *  Copyright (c) 2011 The
WebRTC project authors. All Rights Reserved.
On 2016/10/06 06:23:39, peah-webrtc wrote:
> On 2016/10/05 12:54:53, hlundin-webrtc wrote:
> > Is this new or old? Should it be 2011 or 2016?
> 
> This is basically what remained when the former include file was edited. It is
> actually the former renamed include file, but since it is almost totally
changed
> I think a data change should be motivated. I'll change that. Please let me
know,
> though, if you think otherwise.
> 
> Done.

If some significant part of the old file remains in the new, I think the old
year should be used. But if it is only trivial parts (like the copyright notice)
that remains, then stamp it 2016.

[peah-webrtc, 2016-10-06 12:41:44]

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
File webrtc/modules/audio_processing/utility/ooura_fft.h (right):

https://codereview.webrtc.org/2348213002/diff/280001/webrtc/modules/audio_pro...
webrtc/modules/audio_processing/utility/ooura_fft.h:2: *  Copyright (c) 2011 The
WebRTC project authors. All Rights Reserved.
On 2016/10/06 08:48:44, hlundin-webrtc wrote:
> On 2016/10/06 06:23:39, peah-webrtc wrote:
> > On 2016/10/05 12:54:53, hlundin-webrtc wrote:
> > > Is this new or old? Should it be 2011 or 2016?
> > 
> > This is basically what remained when the former include file was edited. It
is
> > actually the former renamed include file, but since it is almost totally
> changed
> > I think a data change should be motivated. I'll change that. Please let me
> know,
> > though, if you think otherwise.
> > 
> > Done.
> 
> If some significant part of the old file remains in the new, I think the old
> year should be used. But if it is only trivial parts (like the copyright
notice)
> that remains, then stamp it 2016.

Acknowledged.

[peah-webrtc, 2016-10-06 12:44:50]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2016-10-06 12:44:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2348213002/#ps320001 (title:
"Rebase")

[commit-bot: I haz the power, 2016-10-06 12:44:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-06 13:04:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 13:04:17]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9033)

[peah-webrtc, 2016-10-06 13:45:40]

Description was changed from

==========
The FFT functionality in aec_rdft* is based on legacy C
code which is not thread-safe in the sense that the 
rdft_init method can only be run in a single-threaded.

Currently, inside WebRTC multiple instances of the audio-
processing module are set up which means that the init
method may be run concurrently.

In order to avoid having to protect the init method with
a lock to ensure single-threaded behavior that, this CL
places the FFT functionality inside a class so that there
is no global component of the FFT functionality.

Note that:
1) The nonstandard header for the ooura_fft.cc was copied 
   from the aec_rdft.cc header, and augmented with a 
   description of the changes introduced in this CL.
2) The clang warnings for the ooura_fft_sse2.cc, 
   ooura_fft_neon.cc and ooura_fft_mips.cc were not 
   addressed as this code was kept as it was before this CL
3) Clang-format was run on all files apart from 
   ooura_fft_mips.cc (as that would change the format of
   the inline assempbly code).


BUG=chromium:638583
==========

to

==========
The FFT functionality in aec_rdft* is based on legacy C
code which is not thread-safe in the sense that the 
rdft_init method can only be run in a single-threaded.

Currently, inside WebRTC multiple instances of the audio-
processing module are set up which means that the init
method may be run concurrently.

In order to avoid having to protect the init method with
a lock to ensure single-threaded behavior that, this CL
places the FFT functionality inside a class so that there
is no global component of the FFT functionality.

Note that:
1) The nonstandard header for the ooura_fft.cc was copied 
   from the aec_rdft.cc header, and augmented with a 
   description of the changes introduced in this CL.
2) The clang warnings for the ooura_fft_sse2.cc, 
   ooura_fft_neon.cc and ooura_fft_mips.cc were not 
   addressed as this code was kept as it was before this CL
3) Clang-format was run on all files apart from 
   ooura_fft_mips.cc (as that would change the format of
   the inline assempbly code).

Adding bypass of presubmit to avoid code style and header errors caused by the
fact that files with legacy code are being renamed.

NOPRESUBMIT=true

BUG=chromium:638583
==========

[peah-webrtc, 2016-10-06 13:45:56]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2016-10-06 13:46:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-06 13:46:23]

Description was changed from

==========
The FFT functionality in aec_rdft* is based on legacy C
code which is not thread-safe in the sense that the 
rdft_init method can only be run in a single-threaded.

Currently, inside WebRTC multiple instances of the audio-
processing module are set up which means that the init
method may be run concurrently.

In order to avoid having to protect the init method with
a lock to ensure single-threaded behavior that, this CL
places the FFT functionality inside a class so that there
is no global component of the FFT functionality.

Note that:
1) The nonstandard header for the ooura_fft.cc was copied 
   from the aec_rdft.cc header, and augmented with a 
   description of the changes introduced in this CL.
2) The clang warnings for the ooura_fft_sse2.cc, 
   ooura_fft_neon.cc and ooura_fft_mips.cc were not 
   addressed as this code was kept as it was before this CL
3) Clang-format was run on all files apart from 
   ooura_fft_mips.cc (as that would change the format of
   the inline assempbly code).

Adding bypass of presubmit to avoid code style and header errors caused by the
fact that files with legacy code are being renamed.

NOPRESUBMIT=true

BUG=chromium:638583
==========

to

==========
The FFT functionality in aec_rdft* is based on legacy C
code which is not thread-safe in the sense that the 
rdft_init method can only be run in a single-threaded.

Currently, inside WebRTC multiple instances of the audio-
processing module are set up which means that the init
method may be run concurrently.

In order to avoid having to protect the init method with
a lock to ensure single-threaded behavior that, this CL
places the FFT functionality inside a class so that there
is no global component of the FFT functionality.

Note that:
1) The nonstandard header for the ooura_fft.cc was copied 
   from the aec_rdft.cc header, and augmented with a 
   description of the changes introduced in this CL.
2) The clang warnings for the ooura_fft_sse2.cc, 
   ooura_fft_neon.cc and ooura_fft_mips.cc were not 
   addressed as this code was kept as it was before this CL
3) Clang-format was run on all files apart from 
   ooura_fft_mips.cc (as that would change the format of
   the inline assempbly code).

Adding bypass of presubmit to avoid code style and header errors caused by the
fact that files with legacy code are being renamed.

NOPRESUBMIT=true

BUG=chromium:638583
==========

[commit-bot: I haz the power, 2016-10-06 13:46:24]

Committed patchset #3 (id:320001)

[commit-bot: I haz the power, 2016-10-06 13:46:33]

Description was changed from

==========
The FFT functionality in aec_rdft* is based on legacy C
code which is not thread-safe in the sense that the 
rdft_init method can only be run in a single-threaded.

Currently, inside WebRTC multiple instances of the audio-
processing module are set up which means that the init
method may be run concurrently.

In order to avoid having to protect the init method with
a lock to ensure single-threaded behavior that, this CL
places the FFT functionality inside a class so that there
is no global component of the FFT functionality.

Note that:
1) The nonstandard header for the ooura_fft.cc was copied 
   from the aec_rdft.cc header, and augmented with a 
   description of the changes introduced in this CL.
2) The clang warnings for the ooura_fft_sse2.cc, 
   ooura_fft_neon.cc and ooura_fft_mips.cc were not 
   addressed as this code was kept as it was before this CL
3) Clang-format was run on all files apart from 
   ooura_fft_mips.cc (as that would change the format of
   the inline assempbly code).

Adding bypass of presubmit to avoid code style and header errors caused by the
fact that files with legacy code are being renamed.

NOPRESUBMIT=true

BUG=chromium:638583
==========

to

==========
The FFT functionality in aec_rdft* is based on legacy C
code which is not thread-safe in the sense that the
rdft_init method can only be run in a single-threaded.

Currently, inside WebRTC multiple instances of the audio-
processing module are set up which means that the init
method may be run concurrently.

In order to avoid having to protect the init method with
a lock to ensure single-threaded behavior that, this CL
places the FFT functionality inside a class so that there
is no global component of the FFT functionality.

Note that:
1) The nonstandard header for the ooura_fft.cc was copied
   from the aec_rdft.cc header, and augmented with a
   description of the changes introduced in this CL.
2) The clang warnings for the ooura_fft_sse2.cc,
   ooura_fft_neon.cc and ooura_fft_mips.cc were not
   addressed as this code was kept as it was before this CL
3) Clang-format was run on all files apart from
   ooura_fft_mips.cc (as that would change the format of
   the inline assempbly code).

Adding bypass of presubmit to avoid code style and header errors caused by the
fact that files with legacy code are being renamed.

NOPRESUBMIT=true

BUG=chromium:638583

Committed: https://crrev.com/81b9291dfddbfe1bd940ac7aab9a1b41c2b9c188
Cr-Commit-Position: refs/heads/master@{#14554}
==========

[commit-bot: I haz the power, 2016-10-06 13:46:35]

Patchset 3 (id:??) landed as
https://crrev.com/81b9291dfddbfe1bd940ac7aab9a1b41c2b9c188
Cr-Commit-Position: refs/heads/master@{#14554}