Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2440963002: GN: Move xmllite_xmpp_unittests into webrtc/libjingle (Closed)

Created:
4 years, 2 months ago by kjellander_webrtc
Modified:
4 years, 1 month ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Move xmllite_xmpp_unittests into webrtc/libjingle Moving one of the targets that shouldn't pollute the already large webrtc/BUILD.gn file. BUG=webrtc:6440 NOTRY=True Committed: https://crrev.com/eee9c0e3ec4f4eaf26c4b39e9044586d9e5a4a16 Cr-Commit-Position: refs/heads/master@{#14970}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -42 lines) Patch
M webrtc/BUILD.gn View 1 2 chunks +1 line, -41 lines 0 comments Download
M webrtc/build/gn_isolate_map.pyl View 1 1 chunk +1 line, -1 line 0 comments Download
A webrtc/libjingle/BUILD.gn View 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
kjellander_webrtc
Splitting out one of the changes I did in https://codereview.webrtc.org/2377163004/ to make reviewing easier.
4 years, 2 months ago (2016-10-21 11:36:22 UTC) #2
ehmaldonado_chromium
On 2016/10/21 11:36:22, kjellander_webrtc wrote: > Splitting out one of the changes I did in ...
4 years, 2 months ago (2016-10-21 11:39:17 UTC) #3
kjellander_webrtc
On 2016/10/21 11:39:17, ehmaldonado_chromium wrote: > On 2016/10/21 11:36:22, kjellander_webrtc wrote: > > Splitting out ...
4 years, 2 months ago (2016-10-21 11:40:14 UTC) #4
kjellander_webrtc
I'll wait for https://codereview.chromium.org/2443643002/ and moving of the config to our own repo before proceeding ...
4 years, 1 month ago (2016-10-24 04:28:59 UTC) #5
ehmaldonado_webrtc
On 2016/10/24 04:28:59, kjellander_webrtc wrote: > I'll wait for https://codereview.chromium.org/2443643002/ and moving of the > ...
4 years, 1 month ago (2016-11-03 17:06:06 UTC) #6
kjellander_webrtc
On 2016/11/03 17:06:06, ehmaldonado_webrtc wrote: > On 2016/10/24 04:28:59, kjellander_webrtc wrote: > > I'll wait ...
4 years, 1 month ago (2016-11-07 21:10:00 UTC) #7
ehmaldonado_webrtc
On 2016/11/07 21:10:00, kjellander_webrtc wrote: > On 2016/11/03 17:06:06, ehmaldonado_webrtc wrote: > > On 2016/10/24 ...
4 years, 1 month ago (2016-11-08 10:38:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2440963002/20001
4 years, 1 month ago (2016-11-08 11:14:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 11:18:40 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 11:18:47 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eee9c0e3ec4f4eaf26c4b39e9044586d9e5a4a16
Cr-Commit-Position: refs/heads/master@{#14970}

Powered by Google App Engine
This is Rietveld 408576698