Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: webrtc/BUILD.gn

Issue 2440963002: GN: Move xmllite_xmpp_unittests into webrtc/libjingle (Closed)
Patch Set: Rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/build/gn_isolate_map.pyl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/BUILD.gn
diff --git a/webrtc/BUILD.gn b/webrtc/BUILD.gn
index d1f52b32fe96169c82938cc965fe59ae54daafe1..e8fc26407cc4ea853c437d7d7ee0799fc99114bd 100644
--- a/webrtc/BUILD.gn
+++ b/webrtc/BUILD.gn
@@ -295,10 +295,10 @@ if (!build_with_chromium) {
":video_engine_tests",
":webrtc_nonparallel_tests",
":webrtc_perf_tests",
- ":xmllite_xmpp_unittests",
"api:peerconnection_unittests",
"common_audio:common_audio_unittests",
"common_video:common_video_unittests",
+ "libjingle:xmllite_xmpp_unittests",
"media:rtc_media_unittests",
"modules:modules_tests",
"modules:modules_unittests",
@@ -575,46 +575,6 @@ if (rtc_include_tests) {
}
}
- rtc_test("xmllite_xmpp_unittests") {
- configs += [ ":rtc_unittests_config" ]
-
- if (!build_with_chromium && is_clang) {
- # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
- suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
- }
-
- deps = [
- "base:rtc_base_tests_utils",
- "libjingle/xmllite:rtc_xmllite",
- "libjingle/xmpp:rtc_xmpp",
- "//testing/gtest",
- ]
-
- sources = [
- "libjingle/xmllite/qname_unittest.cc",
- "libjingle/xmllite/xmlbuilder_unittest.cc",
- "libjingle/xmllite/xmlelement_unittest.cc",
- "libjingle/xmllite/xmlnsstack_unittest.cc",
- "libjingle/xmllite/xmlparser_unittest.cc",
- "libjingle/xmllite/xmlprinter_unittest.cc",
- "libjingle/xmpp/fakexmppclient.h",
- "libjingle/xmpp/hangoutpubsubclient_unittest.cc",
- "libjingle/xmpp/jid_unittest.cc",
- "libjingle/xmpp/mucroomconfigtask_unittest.cc",
- "libjingle/xmpp/mucroomdiscoverytask_unittest.cc",
- "libjingle/xmpp/mucroomlookuptask_unittest.cc",
- "libjingle/xmpp/mucroomuniquehangoutidtask_unittest.cc",
- "libjingle/xmpp/pingtask_unittest.cc",
- "libjingle/xmpp/pubsubclient_unittest.cc",
- "libjingle/xmpp/pubsubtasks_unittest.cc",
- "libjingle/xmpp/util_unittest.cc",
- "libjingle/xmpp/util_unittest.h",
- "libjingle/xmpp/xmppengine_unittest.cc",
- "libjingle/xmpp/xmpplogintask_unittest.cc",
- "libjingle/xmpp/xmppstanzaparser_unittest.cc",
- ]
- }
-
# TODO(pbos): Rename test suite, this is no longer "just" for video targets.
video_engine_tests_resources = [
"//resources/foreman_cif_short.yuv",
« no previous file with comments | « no previous file | webrtc/build/gn_isolate_map.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698