Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2438013003: Use variadic templates instead of pump for RefCountedObject (Closed)

Created:
4 years, 2 months ago by danilchap
Modified:
4 years, 2 months ago
Reviewers:
tommi, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use variadic templates instead of pump for RefCountedObject BUG=None Committed: https://crrev.com/97abf244ca148bb0d8bb5d2eb235f6d1cd99a958 Cr-Commit-Position: refs/heads/master@{#14714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -232 lines) Patch
M webrtc/base/refcountedobject.h View 3 chunks +4 lines, -168 lines 0 comments Download
D webrtc/base/refcountedobject.h.pump View 1 chunk +0 lines, -64 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
danilchap
What are benefits of pump over variadic templates?
4 years, 2 months ago (2016-10-20 11:06:18 UTC) #2
perkj_webrtc
None that I know of. I just happened to know about pump and though about ...
4 years, 2 months ago (2016-10-20 13:52:25 UTC) #4
tommi
nice! lgtm
4 years, 2 months ago (2016-10-20 13:53:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2438013003/1
4 years, 2 months ago (2016-10-20 13:55:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on ...
4 years, 2 months ago (2016-10-20 15:56:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2438013003/1
4 years, 2 months ago (2016-10-20 18:24:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) presubmit on ...
4 years, 2 months ago (2016-10-20 20:25:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2438013003/1
4 years, 2 months ago (2016-10-20 21:32:51 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 22:19:33 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-20 22:19:43 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97abf244ca148bb0d8bb5d2eb235f6d1cd99a958
Cr-Commit-Position: refs/heads/master@{#14714}

Powered by Google App Engine
This is Rietveld 408576698