Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: webrtc/base/refcountedobject.h

Issue 2438013003: Use variadic templates instead of pump for RefCountedObject (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/base/refcountedobject.h.pump » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/refcountedobject.h
diff --git a/webrtc/base/refcountedobject.h b/webrtc/base/refcountedobject.h
index ee2ec108671cbdf805736448d10ef69678655760..285ed36b1dca4fa2c02ef1dd5d37907c0b134cf9 100644
--- a/webrtc/base/refcountedobject.h
+++ b/webrtc/base/refcountedobject.h
@@ -1,7 +1,3 @@
-// This file was GENERATED by command:
-// pump.py refcountedobject.h.pump
-// DO NOT EDIT BY HAND!!!
-
/*
* Copyright 2016 The WebRTC Project Authors. All rights reserved.
*
@@ -11,10 +7,6 @@
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
-
-// To generate refcount.h from refcount.h.pump, execute:
-// ./testing/gtest/scripts/pump.py ./webrtc/base/refcountedobject.h.pump
-
#ifndef WEBRTC_BASE_REFCOUNTEDOBJECT_H_
#define WEBRTC_BASE_REFCOUNTEDOBJECT_H_
@@ -31,168 +23,12 @@ class RefCountedObject : public T {
template <class P0>
explicit RefCountedObject(P0&& p0) : T(std::forward<P0>(p0)) {}
- template <class P0, class P1>
- RefCountedObject(P0&& p0, P1&& p1)
- : T(std::forward<P0>(p0), std::forward<P1>(p1)) {}
- template <class P0, class P1, class P2>
- RefCountedObject(P0&& p0, P1&& p1, P2&& p2)
- : T(std::forward<P0>(p0), std::forward<P1>(p1), std::forward<P2>(p2)) {}
- template <class P0, class P1, class P2, class P3>
- RefCountedObject(P0&& p0, P1&& p1, P2&& p2, P3&& p3)
- : T(std::forward<P0>(p0),
- std::forward<P1>(p1),
- std::forward<P2>(p2),
- std::forward<P3>(p3)) {}
- template <class P0, class P1, class P2, class P3, class P4>
- RefCountedObject(P0&& p0, P1&& p1, P2&& p2, P3&& p3, P4&& p4)
- : T(std::forward<P0>(p0),
- std::forward<P1>(p1),
- std::forward<P2>(p2),
- std::forward<P3>(p3),
- std::forward<P4>(p4)) {}
- template <class P0, class P1, class P2, class P3, class P4, class P5>
- RefCountedObject(P0&& p0, P1&& p1, P2&& p2, P3&& p3, P4&& p4, P5&& p5)
- : T(std::forward<P0>(p0),
- std::forward<P1>(p1),
- std::forward<P2>(p2),
- std::forward<P3>(p3),
- std::forward<P4>(p4),
- std::forward<P5>(p5)) {}
- template <class P0,
- class P1,
- class P2,
- class P3,
- class P4,
- class P5,
- class P6>
- RefCountedObject(P0&& p0,
- P1&& p1,
- P2&& p2,
- P3&& p3,
- P4&& p4,
- P5&& p5,
- P6&& p6)
- : T(std::forward<P0>(p0),
- std::forward<P1>(p1),
- std::forward<P2>(p2),
- std::forward<P3>(p3),
- std::forward<P4>(p4),
- std::forward<P5>(p5),
- std::forward<P6>(p6)) {}
- template <class P0,
- class P1,
- class P2,
- class P3,
- class P4,
- class P5,
- class P6,
- class P7>
- RefCountedObject(P0&& p0,
- P1&& p1,
- P2&& p2,
- P3&& p3,
- P4&& p4,
- P5&& p5,
- P6&& p6,
- P7&& p7)
- : T(std::forward<P0>(p0),
- std::forward<P1>(p1),
- std::forward<P2>(p2),
- std::forward<P3>(p3),
- std::forward<P4>(p4),
- std::forward<P5>(p5),
- std::forward<P6>(p6),
- std::forward<P7>(p7)) {}
- template <class P0,
- class P1,
- class P2,
- class P3,
- class P4,
- class P5,
- class P6,
- class P7,
- class P8>
- RefCountedObject(P0&& p0,
- P1&& p1,
- P2&& p2,
- P3&& p3,
- P4&& p4,
- P5&& p5,
- P6&& p6,
- P7&& p7,
- P8&& p8)
- : T(std::forward<P0>(p0),
- std::forward<P1>(p1),
- std::forward<P2>(p2),
- std::forward<P3>(p3),
- std::forward<P4>(p4),
- std::forward<P5>(p5),
- std::forward<P6>(p6),
- std::forward<P7>(p7),
- std::forward<P8>(p8)) {}
- template <class P0,
- class P1,
- class P2,
- class P3,
- class P4,
- class P5,
- class P6,
- class P7,
- class P8,
- class P9>
- RefCountedObject(P0&& p0,
- P1&& p1,
- P2&& p2,
- P3&& p3,
- P4&& p4,
- P5&& p5,
- P6&& p6,
- P7&& p7,
- P8&& p8,
- P9&& p9)
- : T(std::forward<P0>(p0),
- std::forward<P1>(p1),
- std::forward<P2>(p2),
- std::forward<P3>(p3),
- std::forward<P4>(p4),
- std::forward<P5>(p5),
- std::forward<P6>(p6),
- std::forward<P7>(p7),
- std::forward<P8>(p8),
- std::forward<P9>(p9)) {}
- template <class P0,
- class P1,
- class P2,
- class P3,
- class P4,
- class P5,
- class P6,
- class P7,
- class P8,
- class P9,
- class P10>
- RefCountedObject(P0&& p0,
- P1&& p1,
- P2&& p2,
- P3&& p3,
- P4&& p4,
- P5&& p5,
- P6&& p6,
- P7&& p7,
- P8&& p8,
- P9&& p9,
- P10&& p10)
+
+ template <class P0, class P1, class... Args>
+ RefCountedObject(P0&& p0, P1&& p1, Args&&... args)
: T(std::forward<P0>(p0),
std::forward<P1>(p1),
- std::forward<P2>(p2),
- std::forward<P3>(p3),
- std::forward<P4>(p4),
- std::forward<P5>(p5),
- std::forward<P6>(p6),
- std::forward<P7>(p7),
- std::forward<P8>(p8),
- std::forward<P9>(p9),
- std::forward<P10>(p10)) {}
+ std::forward<Args>(args)...) {}
virtual int AddRef() const { return AtomicOps::Increment(&ref_count_); }
« no previous file with comments | « no previous file | webrtc/base/refcountedobject.h.pump » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698