Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2437453003: Remove VideoCodec resolution validation. (Closed)

Created:
4 years, 2 months ago by perkj_webrtc
Modified:
4 years, 2 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VideoCodec resolution validation. This is needed to be able to land https://codereview.webrtc.org/2408153002/ "Remove cricket::VideoCodec with, height and framerate properties" without breaking upstream projects. BUG=webrtc:5332 TBR=pthatcher@webrtc.org Committed: https://crrev.com/061ea0df0356facdbd002c3b9952eb19b2e6b531 Cr-Commit-Position: refs/heads/master@{#14681}

Patch Set 1 #

Patch Set 2 : Remove broken tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M webrtc/media/base/codec.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/media/base/codec_unittest.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
perkj_webrtc
4 years, 2 months ago (2016-10-19 11:48:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2437453003/20001
4 years, 2 months ago (2016-10-19 11:49:13 UTC) #6
perkj_webrtc
4 years, 2 months ago (2016-10-19 11:58:14 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
061ea0df0356facdbd002c3b9952eb19b2e6b531 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698