Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: webrtc/media/engine/webrtcvideoengine2_unittest.cc

Issue 2437453003: Remove VideoCodec resolution validation. (Closed)
Patch Set: Remove broken tests. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/base/codec_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvideoengine2_unittest.cc
diff --git a/webrtc/media/engine/webrtcvideoengine2_unittest.cc b/webrtc/media/engine/webrtcvideoengine2_unittest.cc
index 0a40e0469d65fa02e03acb1ee7064aa7ea955638..0355cd5273b1435f389c35784c623741043fb92f 100644
--- a/webrtc/media/engine/webrtcvideoengine2_unittest.cc
+++ b/webrtc/media/engine/webrtcvideoengine2_unittest.cc
@@ -2518,20 +2518,6 @@ TEST_F(WebRtcVideoChannel2Test, SetSendCodecsWithMaxQuantization) {
EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
}
-TEST_F(WebRtcVideoChannel2Test, SetSendCodecsRejectBadDimensions) {
- cricket::VideoSendParameters parameters;
- parameters.codecs.push_back(kVp8Codec);
-
- parameters.codecs[0].width = 0;
- EXPECT_FALSE(channel_->SetSendParameters(parameters))
- << "Codec set though codec width is zero.";
-
- parameters.codecs[0].width = kVp8Codec.width;
- parameters.codecs[0].height = 0;
- EXPECT_FALSE(channel_->SetSendParameters(parameters))
- << "Codec set though codec height is zero.";
-}
-
TEST_F(WebRtcVideoChannel2Test, SetSendCodecsRejectBadPayloadTypes) {
// TODO(pbos): Should we only allow the dynamic range?
static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
« no previous file with comments | « webrtc/media/base/codec_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698