Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2436913002: Move shared_desktop_frame.cc to webrtc/modules/desktop_capture:primitives (Closed)

Created:
4 years, 2 months ago by Sergey Ulanov
Modified:
4 years, 2 months ago
Reviewers:
nicholss
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move shared_desktop_frame.cc to webrtc/modules/desktop_capture:primitives Previously shared_desktop_frame.cc wasn't in primitives target, but it is used in remoting client on android and the client should depend only on primitives, but not desktop_capture overall. BUG=653612 R=nicholss@chromium.org Committed: https://crrev.com/58000a0c3df0d69318b665610d8a54dbf9b6fe23 Cr-Commit-Position: refs/heads/master@{#14709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M webrtc/modules/desktop_capture/BUILD.gn View 2 chunks +6 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/shared_desktop_frame.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
Sergey Ulanov
4 years, 2 months ago (2016-10-19 23:24:27 UTC) #2
nicholss
LGTM, thanks for doing that for me!
4 years, 2 months ago (2016-10-19 23:28:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2436913002/1
4 years, 2 months ago (2016-10-19 23:39:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on ...
4 years, 2 months ago (2016-10-20 01:39:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2436913002/1
4 years, 2 months ago (2016-10-20 15:28:09 UTC) #9
Sergey Ulanov
4 years, 2 months ago (2016-10-20 16:34:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58000a0c3df0d69318b665610d8a54dbf9b6fe23 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698