Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2436503004: Enable clang style plugin in webrtc/modules/desktop_capture (Closed)

Created:
4 years, 2 months ago by Sergey Ulanov
Modified:
4 years, 1 month ago
Reviewers:
Hzj_jie
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable clang style plugin in webrtc/modules/desktop_capture Enabled the plugin and cleaned up all issues it found, mainly virtual destructors not being marked as override. BUG=webrtc:163 Committed: https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d Cr-Commit-Position: refs/heads/master@{#14793}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Patch Set 4 : mac,win #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -42 lines) Patch
M webrtc/modules/desktop_capture/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/desktop_capture/cropping_window_capturer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/desktop_and_cursor_composer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/desktop_and_cursor_composer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/desktop_capture_options.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_capture_options.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_frame_win.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/mac/desktop_configuration.h View 1 2 3 4 5 6 4 chunks +14 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/mac/desktop_configuration.mm View 1 2 3 4 5 6 1 chunk +23 lines, -11 lines 0 comments Download
M webrtc/modules/desktop_capture/mouse_cursor_monitor_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/mouse_cursor_monitor_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_mock_objects.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/win/d3d_device.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/win/d3d_device.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/win/dxgi_adapter_duplicator.h View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/win/dxgi_adapter_duplicator.cc View 1 2 3 4 5 1 chunk +5 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/win/dxgi_texture.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/win/dxgi_texture.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/window_capturer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_null.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_x11.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 37 (21 generated)
Sergey Ulanov
4 years, 2 months ago (2016-10-19 23:41:23 UTC) #2
Hzj_jie
Only a comment about the move constructor in DesktopCaptureOptions, others lgtm. https://codereview.chromium.org/2436503004/diff/1/webrtc/modules/desktop_capture/desktop_capture_options.h File webrtc/modules/desktop_capture/desktop_capture_options.h (right): ...
4 years, 2 months ago (2016-10-19 23:53:32 UTC) #4
Sergey Ulanov
https://codereview.chromium.org/2436503004/diff/1/webrtc/modules/desktop_capture/desktop_capture_options.h File webrtc/modules/desktop_capture/desktop_capture_options.h (right): https://codereview.chromium.org/2436503004/diff/1/webrtc/modules/desktop_capture/desktop_capture_options.h#newcode37 webrtc/modules/desktop_capture/desktop_capture_options.h:37: DesktopCaptureOptions(const DesktopCaptureOptions& options); On 2016/10/19 23:53:32, Hzj_jie wrote: > ...
4 years, 2 months ago (2016-10-20 00:00:25 UTC) #5
Hzj_jie
lgtm
4 years, 2 months ago (2016-10-20 00:01:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2436503004/20001
4 years, 2 months ago (2016-10-21 16:35:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/2327) win_x64_rel on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 2 months ago (2016-10-21 16:37:58 UTC) #10
Hzj_jie
https://codereview.chromium.org/2436503004/diff/20001/webrtc/modules/desktop_capture/win/dxgi_texture.h File webrtc/modules/desktop_capture/win/dxgi_texture.h (right): https://codereview.chromium.org/2436503004/diff/20001/webrtc/modules/desktop_capture/win/dxgi_texture.h#newcode32 webrtc/modules/desktop_capture/win/dxgi_texture.h:32: ~DxgiTexture() override = default; Ah, this is the base ...
4 years, 2 months ago (2016-10-23 19:57:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2436503004/40001
4 years, 1 month ago (2016-10-24 17:23:36 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/18758) mac_rel on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 1 month ago (2016-10-24 17:28:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2436503004/60001
4 years, 1 month ago (2016-10-24 21:12:33 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/15476) mac_rel on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 1 month ago (2016-10-24 21:15:05 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2436503004/100001
4 years, 1 month ago (2016-10-26 19:33:26 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/15554)
4 years, 1 month ago (2016-10-26 19:36:16 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2436503004/120001
4 years, 1 month ago (2016-10-26 19:45:06 UTC) #33
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 1 month ago (2016-10-26 20:15:46 UTC) #35
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 20:15:52 UTC) #37
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d
Cr-Commit-Position: refs/heads/master@{#14793}

Powered by Google App Engine
This is Rietveld 408576698