Enable clang style plugin in webrtc/modules/desktop_capture

Enable clang style plugin in webrtc/modules/desktop_capture

Enabled the plugin and cleaned up all issues it found, mainly virtual
destructors not being marked as override.

BUG=webrtc:163
Committed: https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d
Cr-Commit-Position: refs/heads/master@{#14793}

[Sergey Ulanov, 2016-10-19 23:41:22]

sergeyu@chromium.org changed reviewers:
+ zijiehe@chromium.org

[Sergey Ulanov, 2016-10-19 23:42:24]

Description was changed from

==========
Enable clang style plugin in webrtc/modules/desktop_capture

Enabled the plugin and cleaned up all issues it found, mainly virtual
destructors not being marked as override.
==========

to

==========
Enable clang style plugin in webrtc/modules/desktop_capture

Enabled the plugin and cleaned up all issues it found, mainly virtual
destructors not being marked as override.

BUG=webrtc:163
==========

[Hzj_jie, 2016-10-19 23:53:32]

Only a comment about the move constructor in DesktopCaptureOptions, others lgtm.

https://codereview.chromium.org/2436503004/diff/1/webrtc/modules/desktop_capt...
File webrtc/modules/desktop_capture/desktop_capture_options.h (right):

https://codereview.chromium.org/2436503004/diff/1/webrtc/modules/desktop_capt...
webrtc/modules/desktop_capture/desktop_capture_options.h:37:
DesktopCaptureOptions(const DesktopCaptureOptions& options);
If a copy constructor has been defined, the default move constructor will be
automatically removed. The copy constructor hurts scoped_refptr. I suggest to
also add a move constructor with default implementation.

[Sergey Ulanov, 2016-10-20 00:00:25]

https://codereview.chromium.org/2436503004/diff/1/webrtc/modules/desktop_capt...
File webrtc/modules/desktop_capture/desktop_capture_options.h (right):

https://codereview.chromium.org/2436503004/diff/1/webrtc/modules/desktop_capt...
webrtc/modules/desktop_capture/desktop_capture_options.h:37:
DesktopCaptureOptions(const DesktopCaptureOptions& options);
On 2016/10/19 23:53:32, Hzj_jie wrote:
> If a copy constructor has been defined, the default move constructor will be
> automatically removed. The copy constructor hurts scoped_refptr. I suggest to
> also add a move constructor with default implementation.

Done. Also added assignment operators as they get removed with explicit move
constructor.

[Hzj_jie, 2016-10-20 00:01:39]

lgtm

[Sergey Ulanov, 2016-10-21 16:35:24]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-10-21 16:35:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-21 16:37:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 16:37:58]

Try jobs failed on following builders:
  win_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/2327)
  win_x64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/18834)

[Hzj_jie, 2016-10-23 19:57:31]

https://codereview.chromium.org/2436503004/diff/20001/webrtc/modules/desktop_...
File webrtc/modules/desktop_capture/win/dxgi_texture.h (right):

https://codereview.chromium.org/2436503004/diff/20001/webrtc/modules/desktop_...
webrtc/modules/desktop_capture/win/dxgi_texture.h:32: ~DxgiTexture() override =
default;
Ah, this is the base class, we should still use virtual here.

[Sergey Ulanov, 2016-10-24 17:23:31]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-10-24 17:23:31]

The patchset sent to the CQ was uploaded after l-g-t-m from zijiehe@chromium.org
Link to the patchset: https://codereview.chromium.org/2436503004/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-10-24 17:23:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-24 17:28:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 17:28:27]

Try jobs failed on following builders:
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/18758)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/19442)

[Sergey Ulanov, 2016-10-24 21:12:25]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-10-24 21:12:25]

The patchset sent to the CQ was uploaded after l-g-t-m from zijiehe@chromium.org
Link to the patchset: https://codereview.chromium.org/2436503004/#ps60001
(title: "mac,win")

[commit-bot: I haz the power, 2016-10-24 21:12:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-24 21:15:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 21:15:05]

Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/15476)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/19452)

[Sergey Ulanov, 2016-10-24 21:42:51]

The CQ bit was checked by sergeyu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 21:42:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-24 21:45:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 21:45:25]

Dry run: Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/15479)

[Sergey Ulanov, 2016-10-26 19:33:20]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-10-26 19:33:20]

The patchset sent to the CQ was uploaded after l-g-t-m from zijiehe@chromium.org
Link to the patchset: https://codereview.webrtc.org/2436503004/#ps100001 (title:
".")

[commit-bot: I haz the power, 2016-10-26 19:33:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-26 19:36:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 19:36:16]

Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/15554)

[Sergey Ulanov, 2016-10-26 19:45:00]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-10-26 19:45:01]

The patchset sent to the CQ was uploaded after l-g-t-m from zijiehe@chromium.org
Link to the patchset: https://codereview.webrtc.org/2436503004/#ps120001 (title:
".")

[commit-bot: I haz the power, 2016-10-26 19:45:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-26 20:15:45]

Description was changed from

==========
Enable clang style plugin in webrtc/modules/desktop_capture

Enabled the plugin and cleaned up all issues it found, mainly virtual
destructors not being marked as override.

BUG=webrtc:163
==========

to

==========
Enable clang style plugin in webrtc/modules/desktop_capture

Enabled the plugin and cleaned up all issues it found, mainly virtual
destructors not being marked as override.

BUG=webrtc:163
==========

[commit-bot: I haz the power, 2016-10-26 20:15:46]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-10-26 20:15:51]

Description was changed from

==========
Enable clang style plugin in webrtc/modules/desktop_capture

Enabled the plugin and cleaned up all issues it found, mainly virtual
destructors not being marked as override.

BUG=webrtc:163
==========

to

==========
Enable clang style plugin in webrtc/modules/desktop_capture

Enabled the plugin and cleaned up all issues it found, mainly virtual
destructors not being marked as override.

BUG=webrtc:163

Committed: https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d
Cr-Commit-Position: refs/heads/master@{#14793}
==========

[commit-bot: I haz the power, 2016-10-26 20:15:52]

Patchset 7 (id:??) landed as
https://crrev.com/e183121657fa2daf2985f264cff8dd30cd63b97d
Cr-Commit-Position: refs/heads/master@{#14793}