Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2435923002: Add force_sync option to chromite.checkout. (Closed)

Created:
4 years, 2 months ago by Yoshisato Yanagisawa
Modified:
4 years, 2 months ago
Reviewers:
dnj, iannucci
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add force_sync option to chromite.checkout. "repo sync" sometimes got stuck when it detect changes under it going to sync. Since this is done inside buildbot, we expect repo sync to overwrite anything there. Let me add option to force sync. BUG=657675

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M scripts/slave/recipe_modules/chromite/api.py View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yoshisato Yanagisawa
4 years, 2 months ago (2016-10-20 01:34:19 UTC) #2
iannucci
On 2016/10/20 01:34:19, Yoshisato Yanagisawa wrote: This seems fine to me, but dnj would be ...
4 years, 2 months ago (2016-10-20 22:31:13 UTC) #3
dnj
This can't land b/c there is no coverage of the new code. Recipe engine requires ...
4 years, 2 months ago (2016-10-22 15:13:38 UTC) #4
Yoshisato Yanagisawa
4 years, 2 months ago (2016-10-24 02:35:26 UTC) #5
As I have written in
https://bugs.chromium.org/p/chromium/issues/detail?id=657675, I will withdraw
this cl.
This is not the issue we see every day.  We can tolerate to leave this as-is. 
Allowing it to break make it easy to investigate the cause.

Powered by Google App Engine
This is Rietveld 408576698