Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2435053004: Use NtpTime in RtcpMeasurement instead of uint sec/uint frac. (Closed)

Created:
4 years, 2 months ago by åsapersson
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, henrika_webrtc, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, perkj_webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use NtpTime in RtcpMeasurement instead of uint sec/uint frac. BUG=webrtc:6579 Committed: https://crrev.com/b7e7b49551fec05fe7e11958b610e013131508dd Cr-Commit-Position: refs/heads/master@{#15125}

Patch Set 1 #

Patch Set 2 : add constant for number of rtcp reports #

Patch Set 3 #

Patch Set 4 : change return value int -> bool #

Patch Set 5 #

Patch Set 6 : rebase #

Total comments: 2

Patch Set 7 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -47 lines) Patch
M webrtc/system_wrappers/include/rtp_to_ntp.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/system_wrappers/source/rtp_to_ntp.cc View 1 2 3 4 5 6 chunks +15 lines, -18 lines 0 comments Download
M webrtc/system_wrappers/source/rtp_to_ntp_unittest.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/rtp_streams_synchronizer.cc View 1 2 3 4 5 2 chunks +12 lines, -11 lines 0 comments Download
M webrtc/video/stream_synchronization_unittest.cc View 1 2 3 4 5 6 2 chunks +20 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
stefan-webrtc
https://codereview.webrtc.org/2435053004/diff/90001/webrtc/video/stream_synchronization_unittest.cc File webrtc/video/stream_synchronization_unittest.cc (right): https://codereview.webrtc.org/2435053004/diff/90001/webrtc/video/stream_synchronization_unittest.cc#newcode44 webrtc/video/stream_synchronization_unittest.cc:44: void NowNtp(NtpTime* ntp_time) const { Change to NtpTime GetNowNtp() ...
4 years, 1 month ago (2016-11-13 13:24:59 UTC) #3
åsapersson
https://codereview.webrtc.org/2435053004/diff/90001/webrtc/video/stream_synchronization_unittest.cc File webrtc/video/stream_synchronization_unittest.cc (right): https://codereview.webrtc.org/2435053004/diff/90001/webrtc/video/stream_synchronization_unittest.cc#newcode44 webrtc/video/stream_synchronization_unittest.cc:44: void NowNtp(NtpTime* ntp_time) const { On 2016/11/13 13:24:59, stefan-webrtc ...
4 years, 1 month ago (2016-11-14 16:44:40 UTC) #4
stefan-webrtc
lgtm
4 years, 1 month ago (2016-11-15 08:34:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2435053004/110001
4 years, 1 month ago (2016-11-17 09:13:05 UTC) #11
commit-bot: I haz the power
Committed patchset #7 (id:110001)
4 years, 1 month ago (2016-11-17 10:27:17 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 10:27:29 UTC) #15
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/b7e7b49551fec05fe7e11958b610e013131508dd
Cr-Commit-Position: refs/heads/master@{#15125}

Powered by Google App Engine
This is Rietveld 408576698