webrtc/system_wrappers/source/rtp_to_ntp_unittest.cc - Issue 2435053004: Use NtpTime in RtcpMeasurement instead of uint sec/uint frac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/system_wrappers/source/rtp_to_ntp_unittest.cc

Issue 2435053004: Use NtpTime in RtcpMeasurement instead of uint sec/uint frac. (Closed)

Patch Set: address comment Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/system_wrappers/source/rtp_to_ntp_unittest.cc

diff --git a/webrtc/system_wrappers/source/rtp_to_ntp_unittest.cc b/webrtc/system_wrappers/source/rtp_to_ntp_unittest.cc

index f65a3cf82eb6e92930b5b46fecec084b4f6cd346..bdaaa7d32d552adccbe835af9b1666fdf81a5e48 100644

--- a/webrtc/system_wrappers/source/rtp_to_ntp_unittest.cc

+++ b/webrtc/system_wrappers/source/rtp_to_ntp_unittest.cc

@@ -136,8 +136,8 @@ TEST(UpdateRtcpListTests, InjectRtcpSr) {

EXPECT_TRUE(UpdateRtcpList(kNtpSec, kNtpFrac, kTs, &rtcp, &new_sr));

EXPECT_TRUE(new_sr);

EXPECT_EQ(1u, rtcp.list.size());

- EXPECT_EQ(kNtpSec, rtcp.list.front().ntp_secs);

- EXPECT_EQ(kNtpFrac, rtcp.list.front().ntp_frac);

+ EXPECT_EQ(kNtpSec, rtcp.list.front().ntp_time.seconds());

+ EXPECT_EQ(kNtpFrac, rtcp.list.front().ntp_time.fractions());

EXPECT_EQ(kTs, rtcp.list.front().rtp_timestamp);

// Add second report.

EXPECT_TRUE(UpdateRtcpList(kNtpSec, kNtpFrac + kOneMsInNtpFrac, kTs + 1,