webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h - Issue 2434073003: Extract bitrate allocation of spatial/temporal layers out of codec impl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h

Issue 2434073003: Extract bitrate allocation of spatial/temporal layers out of codec impl. (Closed)

Patch Set: Addressed comments. Moved VideoCodec creation to factory class. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h

diff --git a/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h b/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h

index 3713896a8baca83a15a4b95ee71b279d1d559508..2c2ef44d51169f1c45f601658c711d7f22254dd3 100644

--- a/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h

+++ b/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h

@@ -44,7 +44,8 @@ class H264EncoderImpl : public H264Encoder {

int32_t RegisterEncodeCompleteCallback(

EncodedImageCallback* callback) override;

- int32_t SetRates(uint32_t bitrate, uint32_t framerate) override;

+ int32_t SetRateAllocation(const BitrateAllocation& bitrate_allocation,

+ uint32_t framerate) override;

// The result of encoding - an EncodedImage and RTPFragmentationHeader - are

// passed to the encode complete callback.