Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h

Issue 2434073003: Extract bitrate allocation of spatial/temporal layers out of codec impl. (Closed)
Patch Set: Addressed comments. Moved VideoCodec creation to factory class. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 * 9 *
10 */ 10 */
(...skipping 26 matching lines...) Expand all
37 // - maxFramerate 37 // - maxFramerate
38 // - width 38 // - width
39 // - height 39 // - height
40 int32_t InitEncode(const VideoCodec* codec_settings, 40 int32_t InitEncode(const VideoCodec* codec_settings,
41 int32_t number_of_cores, 41 int32_t number_of_cores,
42 size_t /*max_payload_size*/) override; 42 size_t /*max_payload_size*/) override;
43 int32_t Release() override; 43 int32_t Release() override;
44 44
45 int32_t RegisterEncodeCompleteCallback( 45 int32_t RegisterEncodeCompleteCallback(
46 EncodedImageCallback* callback) override; 46 EncodedImageCallback* callback) override;
47 int32_t SetRates(uint32_t bitrate, uint32_t framerate) override; 47 int32_t SetRateAllocation(const BitrateAllocation& bitrate_allocation,
48 uint32_t framerate) override;
48 49
49 // The result of encoding - an EncodedImage and RTPFragmentationHeader - are 50 // The result of encoding - an EncodedImage and RTPFragmentationHeader - are
50 // passed to the encode complete callback. 51 // passed to the encode complete callback.
51 int32_t Encode(const VideoFrame& frame, 52 int32_t Encode(const VideoFrame& frame,
52 const CodecSpecificInfo* codec_specific_info, 53 const CodecSpecificInfo* codec_specific_info,
53 const std::vector<FrameType>* frame_types) override; 54 const std::vector<FrameType>* frame_types) override;
54 55
55 const char* ImplementationName() const override; 56 const char* ImplementationName() const override;
56 57
57 // Unsupported / Do nothing. 58 // Unsupported / Do nothing.
(...skipping 19 matching lines...) Expand all
77 std::unique_ptr<uint8_t[]> encoded_image_buffer_; 78 std::unique_ptr<uint8_t[]> encoded_image_buffer_;
78 EncodedImageCallback* encoded_image_callback_; 79 EncodedImageCallback* encoded_image_callback_;
79 80
80 bool has_reported_init_; 81 bool has_reported_init_;
81 bool has_reported_error_; 82 bool has_reported_error_;
82 }; 83 };
83 84
84 } // namespace webrtc 85 } // namespace webrtc
85 86
86 #endif // WEBRTC_MODULES_VIDEO_CODING_CODECS_H264_H264_ENCODER_IMPL_H_ 87 #endif // WEBRTC_MODULES_VIDEO_CODING_CODECS_H264_H264_ENCODER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698