Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2426073002:
Deflake ChangingNetworkRoute test. (Closed)
|
Created:
4 years, 2 months ago by stefan-webrtc Modified:
4 years, 1 month ago Reviewers:
the sun CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, perkj_webrtc, mflodman Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDeflake ChangingNetworkRoute test.
NOTRY=true
BUG=webrtc:6551
Committed: https://crrev.com/67118201fb0c73e38c5dd05cd920e7ebabc477f1
Cr-Commit-Position: refs/heads/master@{#14764}
Patch Set 1 #
Total comments: 3
Messages
Total messages: 13 (5 generated)
stefan@webrtc.org changed reviewers: + solenberg@webrtc.org
Description was changed from ========== Deflake ChangingNetworkRoute test. BUG=webrtc:6551 ========== to ========== Deflake ChangingNetworkRoute test. NOTRY=true BUG=webrtc:6551 ==========
lgtm https://codereview.webrtc.org/2426073002/diff/1/webrtc/video/video_send_strea... File webrtc/video/video_send_stream_tests.cc (right): https://codereview.webrtc.org/2426073002/diff/1/webrtc/video/video_send_strea... webrtc/video/video_send_stream_tests.cc:1277: EXPECT_GT(call_->GetStats().send_bandwidth_bps, kStartBitrateBps); not _GE?
https://codereview.webrtc.org/2426073002/diff/1/webrtc/video/video_send_strea... File webrtc/video/video_send_stream_tests.cc (right): https://codereview.webrtc.org/2426073002/diff/1/webrtc/video/video_send_strea... webrtc/video/video_send_stream_tests.cc:1277: EXPECT_GT(call_->GetStats().send_bandwidth_bps, kStartBitrateBps); On 2016/10/19 07:46:07, the sun wrote: > not _GE? No, zero is invalid and is what we accidentally set it to in a previous bug.
The CQ bit was checked by stefan@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Deflake ChangingNetworkRoute test. NOTRY=true BUG=webrtc:6551 ========== to ========== Deflake ChangingNetworkRoute test. NOTRY=true BUG=webrtc:6551 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Deflake ChangingNetworkRoute test. NOTRY=true BUG=webrtc:6551 ========== to ========== Deflake ChangingNetworkRoute test. NOTRY=true BUG=webrtc:6551 Committed: https://crrev.com/67118201fb0c73e38c5dd05cd920e7ebabc477f1 Cr-Commit-Position: refs/heads/master@{#14764} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/67118201fb0c73e38c5dd05cd920e7ebabc477f1 Cr-Commit-Position: refs/heads/master@{#14764}
Message was sent while issue was closed.
https://codereview.webrtc.org/2426073002/diff/1/webrtc/video/video_send_strea... File webrtc/video/video_send_stream_tests.cc (right): https://codereview.webrtc.org/2426073002/diff/1/webrtc/video/video_send_strea... webrtc/video/video_send_stream_tests.cc:1277: EXPECT_GT(call_->GetStats().send_bandwidth_bps, kStartBitrateBps); On 2016/10/25 10:37:48, stefan-webrtc (holmer) wrote: > On 2016/10/19 07:46:07, the sun wrote: > > not _GE? > > No, zero is invalid and is what we accidentally set it to in a previous bug. I misread your comment. Sorry... Yes, it should have been GE... :)
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/2445233005/ by ehmaldonado@webrtc.org. The reason for reverting is: Breaks bots in the main waterfall. Example: https://build.chromium.org/p/client.webrtc/builders/Win32%20Debug/builds/9836. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
