webrtc/video/video_send_stream_tests.cc - Issue 2426073002: Deflake ChangingNetworkRoute test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/video/video_send_stream_tests.cc

Issue 2426073002: Deflake ChangingNetworkRoute test. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/video/video_send_stream_tests.cc

diff --git a/webrtc/video/video_send_stream_tests.cc b/webrtc/video/video_send_stream_tests.cc

index d138893ba4cc293155b8daa7595c0f3eb715ef61..20281a35961d6d6468aa243d175eb377a1a23d85 100644

--- a/webrtc/video/video_send_stream_tests.cc

+++ b/webrtc/video/video_send_stream_tests.cc

@@ -1274,7 +1274,7 @@ TEST_F(VideoSendStreamTest, ChangingNetworkRoute) {

// that we correctly ignore any packet loss reported prior to that id.

++new_route.local_network_id;

call_->OnNetworkRouteChanged("transport", new_route);

- EXPECT_EQ(kStartBitrateBps, call_->GetStats().send_bandwidth_bps);

+ EXPECT_GT(call_->GetStats().send_bandwidth_bps, kStartBitrateBps);

the sun 2016/10/19 07:46:07 not _GE?

stefan-webrtc 2016/10/25 10:37:48 No, zero is invalid and is what we accidentally se

stefan-webrtc 2016/10/25 10:58:07 I misread your comment. Sorry... Yes, it should ha

}

private:

« no previous file with comments | « no previous file | no next file » | no next file with comments »