GN: Add missing config //webrtc:common_objc for rtc_sdk_common_objc

GN: Add missing config //webrtc:common_objc for rtc_sdk_common_objc

This makes this target not include the precompiled header, which
is different from GYP.

BUG=webrtc:6412
NOTRY=True

Committed: https://crrev.com/9cc012daf5722e8bf050b8ae743420f839a54bb2
Cr-Commit-Position: refs/heads/master@{#14559}

[kjellander_webrtc, 2016-10-06 19:04:29]

Description was changed from

==========
GN: Add missing config on //webrtc:common_objc for rtc_sdk_common_objc

This makes this target not include the precompiled header, which
is different from GYP.

BUG=webrtc:6412
NOTRY=True
==========

to

==========
GN: Add missing config //webrtc:common_objc for rtc_sdk_common_objc

This makes this target not include the precompiled header, which
is different from GYP.

BUG=webrtc:6412
NOTRY=True
==========

[kjellander_webrtc, 2016-10-06 19:04:29]

kjellander@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[tkchin_webrtc, 2016-10-06 20:50:38]

lgtm

https://codereview.webrtc.org/2402493002/diff/1/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2402493002/diff/1/webrtc/sdk/BUILD.gn#newcode32
webrtc/sdk/BUILD.gn:32: "//build/config/compiler:enable_arc",
enable_arc should be a common objc config I think. There shouldn't be instances
of non-arc code for targets that currently use common_objc that I know of.

[kjellander_webrtc, 2016-10-07 05:09:29]

https://codereview.webrtc.org/2402493002/diff/1/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2402493002/diff/1/webrtc/sdk/BUILD.gn#newcode32
webrtc/sdk/BUILD.gn:32: "//build/config/compiler:enable_arc",
On 2016/10/06 20:50:38, tkchin_webrtc wrote:
> enable_arc should be a common objc config I think. There shouldn't be
instances
> of non-arc code for targets that currently use common_objc that I know of.

If that was possible we certainly should do that. However configs cannot include
other configs in GN, so it's not possible. The workaround for that would be to
introduce our own template for this, but that would mean at least two templates
since both rtc_static_library and rtc_test targets use this. So I won't do it in
this CL at least.

[kjellander_webrtc, 2016-10-07 05:09:33]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-10-07 05:09:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-07 05:18:15]

Description was changed from

==========
GN: Add missing config //webrtc:common_objc for rtc_sdk_common_objc

This makes this target not include the precompiled header, which
is different from GYP.

BUG=webrtc:6412
NOTRY=True
==========

to

==========
GN: Add missing config //webrtc:common_objc for rtc_sdk_common_objc

This makes this target not include the precompiled header, which
is different from GYP.

BUG=webrtc:6412
NOTRY=True
==========

[commit-bot: I haz the power, 2016-10-07 05:18:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-07 05:18:20]

Description was changed from

==========
GN: Add missing config //webrtc:common_objc for rtc_sdk_common_objc

This makes this target not include the precompiled header, which
is different from GYP.

BUG=webrtc:6412
NOTRY=True
==========

to

==========
GN: Add missing config //webrtc:common_objc for rtc_sdk_common_objc

This makes this target not include the precompiled header, which
is different from GYP.

BUG=webrtc:6412
NOTRY=True

Committed: https://crrev.com/9cc012daf5722e8bf050b8ae743420f839a54bb2
Cr-Commit-Position: refs/heads/master@{#14559}
==========

[commit-bot: I haz the power, 2016-10-07 05:18:21]

Patchset 1 (id:??) landed as
https://crrev.com/9cc012daf5722e8bf050b8ae743420f839a54bb2
Cr-Commit-Position: refs/heads/master@{#14559}