Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: webrtc/sdk/BUILD.gn

Issue 2402493002: GN: Add missing config //webrtc:common_objc for rtc_sdk_common_objc (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/BUILD.gn
diff --git a/webrtc/sdk/BUILD.gn b/webrtc/sdk/BUILD.gn
index 4cceb8e1a6e9ee29c012c23aabcf71037afb69f0..f4402c8b452b3a90b516cf44c829a849589c7102 100644
--- a/webrtc/sdk/BUILD.gn
+++ b/webrtc/sdk/BUILD.gn
@@ -27,7 +27,10 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
deps = [
"../base:rtc_base",
]
- configs += [ "//build/config/compiler:enable_arc" ]
+ configs += [
+ "..:common_objc",
+ "//build/config/compiler:enable_arc",
tkchin_webrtc 2016/10/06 20:50:38 enable_arc should be a common objc config I think.
kjellander_webrtc 2016/10/07 05:09:29 If that was possible we certainly should do that.
+ ]
public_configs = [ ":rtc_sdk_common_objc_config" ]
sources = [
"objc/Framework/Classes/NSString+StdString.h",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698