Fix chromium-style warnings.

Fix chromium-style warnings.

Separate the null implementation from rtp_rtcp_defines.h, and follow chromium style guide for virtual functions.

BUG=webrtc:163
Committed: https://crrev.com/509eadd554de6bf938da08071c5d2c2541703134
Cr-Commit-Position: refs/heads/master@{#14738}

[terelius, 2016-10-07 12:29:41]

terelius@webrtc.org changed reviewers:
+ danilchap@webrtc.org, kjellander@webrtc.org

[terelius, 2016-10-07 12:29:42]

PTAL

[danilchap, 2016-10-07 12:42:49]

looks good, but may do not name new files based on where they were, rather what
this classes are.

https://codereview.webrtc.org/2400993002/diff/1/webrtc/modules/rtp_rtcp/BUILD.gn
File webrtc/modules/rtp_rtcp/BUILD.gn (right):

https://codereview.webrtc.org/2400993002/diff/1/webrtc/modules/rtp_rtcp/BUILD...
webrtc/modules/rtp_rtcp/BUILD.gn:136: "source/rtp_rtcp_defines_nullimpl.cc",
may be call this files
null_rtp_callbacks

[kjellander_webrtc, 2016-10-07 12:44:20]

If you're fixing Chromium-style warnings, shouldn't you remove
//build/config/clang:find_bad_constructs somewhere? Or there's more work and
this is just one step?

[terelius, 2016-10-07 12:49:14]

On 2016/10/07 12:44:20, kjellander_webrtc wrote:
> If you're fixing Chromium-style warnings, shouldn't you remove
> //build/config/clang:find_bad_constructs somewhere? Or there's more work and
> this is just one step?

This just fixes the errors coming from rtp_rtcp_defines.h. There are several
other places that also needs to be updated before I can enable the warnings
for the bwe_simulator.

[terelius, 2016-10-07 15:03:37]

https://codereview.webrtc.org/2400993002/diff/1/webrtc/modules/rtp_rtcp/BUILD.gn
File webrtc/modules/rtp_rtcp/BUILD.gn (right):

https://codereview.webrtc.org/2400993002/diff/1/webrtc/modules/rtp_rtcp/BUILD...
webrtc/modules/rtp_rtcp/BUILD.gn:136: "source/rtp_rtcp_defines_nullimpl.cc",
On 2016/10/07 12:42:49, danilchap wrote:
> may be call this files
> null_rtp_callbacks

My reasoning for choosing this name is that the file essentially contains the
null implementations of the interfaces declared in rtcp_defines.h. Since there
are other null objects/callbacks in the RTP module, I prefer a name that
clarifies which objects live in the file. Or do you think we will want to move
in other objects into this file?

[kjellander_webrtc, 2016-10-07 17:00:09]

lgtm

[danilchap, 2016-10-07 17:22:00]

lgtm

https://codereview.webrtc.org/2400993002/diff/1/webrtc/modules/rtp_rtcp/BUILD.gn
File webrtc/modules/rtp_rtcp/BUILD.gn (right):

https://codereview.webrtc.org/2400993002/diff/1/webrtc/modules/rtp_rtcp/BUILD...
webrtc/modules/rtp_rtcp/BUILD.gn:136: "source/rtp_rtcp_defines_nullimpl.cc",
On 2016/10/07 15:03:37, terelius wrote:
> On 2016/10/07 12:42:49, danilchap wrote:
> > may be call this files
> > null_rtp_callbacks
> 
> My reasoning for choosing this name is that the file essentially contains the
> null implementations of the interfaces declared in rtcp_defines.h. Since there
> are other null objects/callbacks in the RTP module, I prefer a name that
> clarifies which objects live in the file. Or do you think we will want to move
> in other objects into this file?

might make sense to move the remaining object into that file too eventually.
(found just one another: NullReceiveStatistics).

for now might better to leave rtp_rtcp_defines_nullimpl to simplify lookup

[terelius, 2016-10-19 15:08:16]

The CQ bit was checked by terelius@webrtc.org

[commit-bot: I haz the power, 2016-10-19 15:08:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-19 17:08:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 17:08:56]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_compile_mips_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_compile_x64_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_compile_x86_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_compile_x86_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_arm on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_asan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_compile_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_libfuzzer_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_msan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_tsan2 on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_ubsan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_ubsan_vptr on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[kjellander_webrtc, 2016-10-19 19:36:35]

On 2016/10/19 17:08:56, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
>   android_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
>   android_compile_mips_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build
> URL)
>   android_compile_x64_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build
> URL)
>   android_compile_x86_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build
> URL)
>   android_compile_x86_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build
> URL)
>   android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
>   android_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
>   android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
>   linux_arm on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
>   linux_asan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
>   linux_compile_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
>   linux_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
>   linux_libfuzzer_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
>   linux_msan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
>   linux_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
>   linux_tsan2 on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
>   linux_ubsan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
>   linux_ubsan_vptr on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
>   presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

There was a CQ outage today that queued up a lot of jobs. It's slowly catching
up now...

[terelius, 2016-10-21 12:21:30]

The CQ bit was checked by terelius@webrtc.org

[commit-bot: I haz the power, 2016-10-21 12:21:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-21 14:22:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 14:22:20]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_compile_mips_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_compile_x64_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_compile_x86_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_compile_x86_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_arm on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_asan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_compile_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_libfuzzer_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_msan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_tsan2 on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_ubsan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_ubsan_vptr on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[terelius, 2016-10-24 08:41:15]

The CQ bit was checked by terelius@webrtc.org

[commit-bot: I haz the power, 2016-10-24 08:41:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-24 10:24:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-24 10:24:30]

Description was changed from

==========
Fix chromium-style warnings.

Separate the null implementation from rtp_rtcp_defines.h, and follow chromium
style guide for virtual functions.

BUG=webrtc:163
==========

to

==========
Fix chromium-style warnings.

Separate the null implementation from rtp_rtcp_defines.h, and follow chromium
style guide for virtual functions.

BUG=webrtc:163

Committed: https://crrev.com/509eadd554de6bf938da08071c5d2c2541703134
Cr-Commit-Position: refs/heads/master@{#14738}
==========

[commit-bot: I haz the power, 2016-10-24 10:24:34]

Patchset 1 (id:??) landed as
https://crrev.com/509eadd554de6bf938da08071c5d2c2541703134
Cr-Commit-Position: refs/heads/master@{#14738}

[terelius, 2016-10-24 16:38:10]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2449523002/ by terelius@webrtc.org.

The reason for reverting is: Broke internal project.