Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: webrtc/modules/rtp_rtcp/BUILD.gn

Issue 2400993002: Fix chromium-style warnings. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/BUILD.gn
diff --git a/webrtc/modules/rtp_rtcp/BUILD.gn b/webrtc/modules/rtp_rtcp/BUILD.gn
index 16a3717092d64c3eea34c7058c5fc525dd16cb7b..790f99a5bad63244e34c3ecbe14aaa11ce55d1a0 100644
--- a/webrtc/modules/rtp_rtcp/BUILD.gn
+++ b/webrtc/modules/rtp_rtcp/BUILD.gn
@@ -133,6 +133,8 @@ rtc_static_library("rtp_rtcp") {
"source/rtp_receiver_video.cc",
"source/rtp_receiver_video.h",
"source/rtp_rtcp_config.h",
+ "source/rtp_rtcp_defines_nullimpl.cc",
danilchap 2016/10/07 12:42:49 may be call this files null_rtp_callbacks
terelius 2016/10/07 15:03:37 My reasoning for choosing this name is that the fi
danilchap 2016/10/07 17:22:00 might make sense to move the remaining object into
+ "source/rtp_rtcp_defines_nullimpl.h",
"source/rtp_rtcp_impl.cc",
"source/rtp_rtcp_impl.h",
"source/rtp_sender.cc",
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698