Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2400443003: Revert of Delete transformadapter.cc and transformadapter.h. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete transformadapter.cc and transformadapter.h. (patchset #2 id:20001 of https://codereview.webrtc.org/2368243002/ ) Reason for revert: This change broke a downstream application. Original issue's description: > Delete transformadapter.cc and transformadapter.h. > > BUG=webrtc:6424 > > Committed: https://crrev.com/2c3c3e27321e4b616bd1222857b2882befc485e3 > Cr-Commit-Position: refs/heads/master@{#14541} TBR=perkj@webrtc.org,pthatcher@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6424 Committed: https://crrev.com/8e7577c468e6d8dad76f8befdb57f759b346a032 Cr-Commit-Position: refs/heads/master@{#14543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -0 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/base/base.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/base/transformadapter.h View 1 chunk +84 lines, -0 lines 0 comments Download
A webrtc/base/transformadapter.cc View 1 chunk +197 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nisse-webrtc
Created Revert of Delete transformadapter.cc and transformadapter.h.
4 years, 2 months ago (2016-10-06 08:37:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2400443003/1
4 years, 2 months ago (2016-10-06 08:37:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 08:37:39 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 08:37:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e7577c468e6d8dad76f8befdb57f759b346a032
Cr-Commit-Position: refs/heads/master@{#14543}

Powered by Google App Engine
This is Rietveld 408576698