Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2368243002: Delete transformadapter.cc and transformadapter.h. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete transformadapter.cc and transformadapter.h. BUG=webrtc:6424 Committed: https://crrev.com/2c3c3e27321e4b616bd1222857b2882befc485e3 Cr-Commit-Position: refs/heads/master@{#14541}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -285 lines) Patch
M webrtc/base/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/base/base.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/base/transformadapter.h View 1 chunk +0 lines, -84 lines 0 comments Download
D webrtc/base/transformadapter.cc View 1 chunk +0 lines, -197 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
nisse-webrtc
More dead code. Do you know the StreamAdapterInterface (which the deleted TransformAdapter inherits), there are ...
4 years, 2 months ago (2016-09-26 12:51:34 UTC) #2
pthatcher1
lgtm I believe StreamAdapterInterface is used by the HTTP code that you're deleting in 2366333002. ...
4 years, 2 months ago (2016-10-03 22:42:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2368243002/1
4 years, 2 months ago (2016-10-05 06:19:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/17361) linux_arm on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 2 months ago (2016-10-05 06:26:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2368243002/20001
4 years, 2 months ago (2016-10-06 07:00:28 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/14760)
4 years, 2 months ago (2016-10-06 07:13:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2368243002/20001
4 years, 2 months ago (2016-10-06 08:14:01 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 08:23:14 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2c3c3e27321e4b616bd1222857b2882befc485e3 Cr-Commit-Position: refs/heads/master@{#14541}
4 years, 2 months ago (2016-10-06 08:23:24 UTC) #19
nisse-webrtc
4 years, 2 months ago (2016-10-06 08:37:30 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2400443003/ by nisse@webrtc.org.

The reason for reverting is: This change broke a downstream application..

Powered by Google App Engine
This is Rietveld 408576698