Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2399463009: Delete RTPSender::BuildRtpHeader function (Closed)

Created:
4 years, 2 months ago by danilchap
Modified:
4 years, 2 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete RTPSender::BuildRtpHeader function and all dependencies BUG=webrtc:5565 Committed: https://crrev.com/b6f1fb53370c973a926bbca1e677b3554edd5ec9 Cr-Commit-Position: refs/heads/master@{#14682}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -915 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 4 chunks +0 lines, -88 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 6 chunks +0 lines, -450 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 16 chunks +48 lines, -377 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
danilchap
4 years, 2 months ago (2016-10-18 16:30:36 UTC) #6
sprang_webrtc
lgtm Woo!
4 years, 2 months ago (2016-10-19 09:44:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2399463009/80001
4 years, 2 months ago (2016-10-19 11:11:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:80001)
4 years, 2 months ago (2016-10-19 13:11:42 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-19 13:20:13 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6f1fb53370c973a926bbca1e677b3554edd5ec9
Cr-Commit-Position: refs/heads/master@{#14682}

Powered by Google App Engine
This is Rietveld 408576698