Delete RTPSender::BuildRtpHeader function

webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 23 matching lines @@
 namespace webrtc {
 
 namespace {
 const int kTransmissionTimeOffsetExtensionId = 1;
 const int kAbsoluteSendTimeExtensionId = 14;
 const int kTransportSequenceNumberExtensionId = 13;
 const int kPayload = 100;
 const int kRtxPayload = 98;
 const uint32_t kTimestamp = 10;
 const uint16_t kSeqNum = 33;
-const int kTimeOffset = 22222;
 const int kMaxPacketLength = 1500;
-const uint32_t kAbsoluteSendTime = 0x00aabbcc;
 const uint8_t kAudioLevel = 0x5a;
 const uint16_t kTransportSequenceNumber = 0xaabbu;
 const uint8_t kAudioLevelExtensionId = 9;
 const int kAudioPayload = 103;
 const uint64_t kStartTime = 123456789;
 const size_t kMaxPaddingSize = 224u;
 const int kVideoRotationExtensionId = 5;
-const VideoRotation kRotation = kVideoRotation_270;
 const size_t kGenericHeaderLength = 1;
 const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
 
 using ::testing::_;
 using ::testing::ElementsAreArray;
 
 const uint8_t* GetPayloadData(const RTPHeader& rtp_header,
                               const uint8_t* packet) {
   return packet + rtp_header.headerLength;
 }
@@ skipping 104 matching lines @@
   testing::NiceMock<MockRtcEventLog> mock_rtc_event_log_;
   MockRtpPacketSender mock_paced_sender_;
   testing::StrictMock<MockTransportSequenceNumberAllocator> seq_num_allocator_;
   testing::StrictMock<MockSendPacketObserver> send_packet_observer_;
   testing::StrictMock<MockTransportFeedbackObserver> feedback_observer_;
   RateLimiter retransmission_rate_limiter_;
   std::unique_ptr<RTPSender> rtp_sender_;
   int payload_;
   LoopbackTransportTest transport_;
   const bool kMarkerBit;
-  uint8_t packet_[kMaxPacketLength];
 
   void VerifyRTPHeaderCommon(const RTPHeader& rtp_header) {
     VerifyRTPHeaderCommon(rtp_header, kMarkerBit, 0);
   }
 
   void VerifyRTPHeaderCommon(const RTPHeader& rtp_header, bool marker_bit) {
     VerifyRTPHeaderCommon(rtp_header, marker_bit, 0);
   }
 
   void VerifyRTPHeaderCommon(const RTPHeader& rtp_header,
                              bool marker_bit,
                              uint8_t number_of_csrcs) {
     EXPECT_EQ(marker_bit, rtp_header.markerBit);
     EXPECT_EQ(payload_, rtp_header.payloadType);
     EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
     EXPECT_EQ(kTimestamp, rtp_header.timestamp);
     EXPECT_EQ(rtp_sender_->SSRC(), rtp_header.ssrc);
     EXPECT_EQ(number_of_csrcs, rtp_header.numCSRCs);
     EXPECT_EQ(0U, rtp_header.paddingLength);
   }
 
+  std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
+                                                  bool marker_bit,
+                                                  uint32_t timestamp,
+                                                  int64_t capture_time_ms) {
+    auto packet = rtp_sender_->AllocatePacket();
+    packet->SetPayloadType(payload_type);
+    packet->SetMarker(marker_bit);
+    packet->SetTimestamp(timestamp);
+    packet->set_capture_time_ms(capture_time_ms);
+    EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
+    return packet;
+  }
+
   void SendPacket(int64_t capture_time_ms, int payload_length) {
     uint32_t timestamp = capture_time_ms * 90;
-    int32_t rtp_length = rtp_sender_->BuildRtpHeader(
-        packet_, kPayload, kMarkerBit, timestamp, capture_time_ms);
-    ASSERT_GE(rtp_length, 0);
+    auto packet =
+        BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
+    packet->AllocatePayload(payload_length);
 
     // Packet should be stored in a send bucket.
-    EXPECT_TRUE(rtp_sender_->SendToNetwork(
-        packet_, payload_length, rtp_length, capture_time_ms,
-        kAllowRetransmission, RtpPacketSender::kNormalPriority));
+    EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
+                                           kAllowRetransmission,
+                                           RtpPacketSender::kNormalPriority));
   }
 
   void SendGenericPayload() {
     const uint32_t kTimestamp = 1234;
     const uint8_t kPayloadType = 127;
     const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
     char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
     EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
                                               0, 1500));
 
@@ skipping 22 matching lines @@
 
   void VerifyCVOPacket(uint8_t* data,
                        size_t len,
                        bool expect_cvo,
                        RtpHeaderExtensionMap* map,
                        uint16_t seq_num,
                        VideoRotation rotation) {
     webrtc::RtpUtility::RtpHeaderParser rtp_parser(data, len);
 
     webrtc::RTPHeader rtp_header;
-    size_t length = static_cast<size_t>(rtp_sender_->BuildRtpHeader(
-        packet_, kPayload, expect_cvo /* marker_bit */, kTimestamp, 0));
-    if (expect_cvo) {
-      ASSERT_EQ(kRtpHeaderSize + rtp_sender_->RtpHeaderExtensionLength(),
-                length);
-    } else {
-      ASSERT_EQ(kRtpHeaderSize, length);
-    }
     ASSERT_TRUE(rtp_parser.Parse(&rtp_header, map));
     ASSERT_FALSE(rtp_parser.RTCP());
     EXPECT_EQ(payload_, rtp_header.payloadType);
     EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
     EXPECT_EQ(kTimestamp, rtp_header.timestamp);
     EXPECT_EQ(rtp_sender_->SSRC(), rtp_header.ssrc);
     EXPECT_EQ(0, rtp_header.numCSRCs);
     EXPECT_EQ(0U, rtp_header.paddingLength);
     EXPECT_EQ(rotation, rtp_header.extension.videoRotation);
   }
@@ skipping 192 matching lines @@
   ASSERT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, -1));
 
   ASSERT_EQ(1u, transport_.sent_packets_.size());
   // Parse the padding packet and verify its timestamp.
   RtpPacketToSend padding_packet(nullptr);
   ASSERT_TRUE(padding_packet.Parse(transport_.sent_packets_[0]->data(),
                                    transport_.sent_packets_[0]->size()));
   EXPECT_EQ(kTimestamp, padding_packet.Timestamp());
 }
 
-TEST_F(RtpSenderTestWithoutPacer, BuildRTPPacket) {
-  size_t length = static_cast<size_t>(rtp_sender_->BuildRtpHeader(
-      packet_, kPayload, kMarkerBit, kTimestamp, 0));
-  ASSERT_EQ(kRtpHeaderSize, length);
-
-  // Verify
-  webrtc::RtpUtility::RtpHeaderParser rtp_parser(packet_, length);
-  webrtc::RTPHeader rtp_header;
-
-  const bool valid_rtp_header = rtp_parser.Parse(&rtp_header, nullptr);
-
-  ASSERT_TRUE(valid_rtp_header);
-  ASSERT_FALSE(rtp_parser.RTCP());
-  VerifyRTPHeaderCommon(rtp_header);
-  EXPECT_EQ(length, rtp_header.headerLength);
-  EXPECT_FALSE(rtp_header.extension.hasTransmissionTimeOffset);
-  EXPECT_FALSE(rtp_header.extension.hasAbsoluteSendTime);
-  EXPECT_FALSE(rtp_header.extension.hasAudioLevel);
-  EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
-  EXPECT_EQ(0u, rtp_header.extension.absoluteSendTime);
-  EXPECT_FALSE(rtp_header.extension.voiceActivity);
-  EXPECT_EQ(0u, rtp_header.extension.audioLevel);
-  EXPECT_EQ(0u, rtp_header.extension.videoRotation);
-}
-
-TEST_F(RtpSenderTestWithoutPacer,
-       BuildRTPPacketWithTransmissionOffsetExtension) {
-  EXPECT_EQ(0, rtp_sender_->SetTransmissionTimeOffset(kTimeOffset));
-  EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
-                   kRtpExtensionTransmissionTimeOffset,
-                   kTransmissionTimeOffsetExtensionId));
-
-  size_t length = static_cast<size_t>(rtp_sender_->BuildRtpHeader(
-      packet_, kPayload, kMarkerBit, kTimestamp, 0));
-  ASSERT_EQ(kRtpHeaderSize + rtp_sender_->RtpHeaderExtensionLength(), length);
-
-  // Verify
-  webrtc::RtpUtility::RtpHeaderParser rtp_parser(packet_, length);
-  webrtc::RTPHeader rtp_header;
-
-  RtpHeaderExtensionMap map;
-  map.Register(kRtpExtensionTransmissionTimeOffset,
-               kTransmissionTimeOffsetExtensionId);
-  const bool valid_rtp_header = rtp_parser.Parse(&rtp_header, &map);
-
-  ASSERT_TRUE(valid_rtp_header);
-  ASSERT_FALSE(rtp_parser.RTCP());
-  VerifyRTPHeaderCommon(rtp_header);
-  EXPECT_EQ(length, rtp_header.headerLength);
-  EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset);
-  EXPECT_EQ(kTimeOffset, rtp_header.extension.transmissionTimeOffset);
-
-  // Parse without map extension
-  webrtc::RTPHeader rtp_header2;
-  const bool valid_rtp_header2 = rtp_parser.Parse(&rtp_header2, nullptr);
-
-  ASSERT_TRUE(valid_rtp_header2);
-  VerifyRTPHeaderCommon(rtp_header2);
-  EXPECT_EQ(length, rtp_header2.headerLength);
-  EXPECT_FALSE(rtp_header2.extension.hasTransmissionTimeOffset);
-  EXPECT_EQ(0, rtp_header2.extension.transmissionTimeOffset);
-}
-
-TEST_F(RtpSenderTestWithoutPacer,
-       BuildRTPPacketWithNegativeTransmissionOffsetExtension) {
-  const int kNegTimeOffset = -500;
-  EXPECT_EQ(0, rtp_sender_->SetTransmissionTimeOffset(kNegTimeOffset));
-  EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
-                   kRtpExtensionTransmissionTimeOffset,
-                   kTransmissionTimeOffsetExtensionId));
-
-  size_t length = static_cast<size_t>(rtp_sender_->BuildRtpHeader(
-      packet_, kPayload, kMarkerBit, kTimestamp, 0));
-  ASSERT_EQ(kRtpHeaderSize + rtp_sender_->RtpHeaderExtensionLength(), length);
-
-  // Verify
-  webrtc::RtpUtility::RtpHeaderParser rtp_parser(packet_, length);
-  webrtc::RTPHeader rtp_header;
-
-  RtpHeaderExtensionMap map;
-  map.Register(kRtpExtensionTransmissionTimeOffset,
-               kTransmissionTimeOffsetExtensionId);
-  const bool valid_rtp_header = rtp_parser.Parse(&rtp_header, &map);
-
-  ASSERT_TRUE(valid_rtp_header);
-  ASSERT_FALSE(rtp_parser.RTCP());
-  VerifyRTPHeaderCommon(rtp_header);
-  EXPECT_EQ(length, rtp_header.headerLength);
-  EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset);
-  EXPECT_EQ(kNegTimeOffset, rtp_header.extension.transmissionTimeOffset);
-}
-
-TEST_F(RtpSenderTestWithoutPacer, BuildRTPPacketWithAbsoluteSendTimeExtension) {
-  EXPECT_EQ(0, rtp_sender_->SetAbsoluteSendTime(kAbsoluteSendTime));
-  EXPECT_EQ(
-      0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
-                                                 kAbsoluteSendTimeExtensionId));
-
-  size_t length = static_cast<size_t>(rtp_sender_->BuildRtpHeader(
-      packet_, kPayload, kMarkerBit, kTimestamp, 0));
-  ASSERT_EQ(kRtpHeaderSize + rtp_sender_->RtpHeaderExtensionLength(), length);
-
-  // Verify
-  webrtc::RtpUtility::RtpHeaderParser rtp_parser(packet_, length);
-  webrtc::RTPHeader rtp_header;
-
-  RtpHeaderExtensionMap map;
-  map.Register(kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId);
-  const bool valid_rtp_header = rtp_parser.Parse(&rtp_header, &map);
-
-  ASSERT_TRUE(valid_rtp_header);
-  ASSERT_FALSE(rtp_parser.RTCP());
-  VerifyRTPHeaderCommon(rtp_header);
-  EXPECT_EQ(length, rtp_header.headerLength);
-  EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime);
-  EXPECT_EQ(kAbsoluteSendTime, rtp_header.extension.absoluteSendTime);
-
-  // Parse without map extension
-  webrtc::RTPHeader rtp_header2;
-  const bool valid_rtp_header2 = rtp_parser.Parse(&rtp_header2, nullptr);
-
-  ASSERT_TRUE(valid_rtp_header2);
-  VerifyRTPHeaderCommon(rtp_header2);
-  EXPECT_EQ(length, rtp_header2.headerLength);
-  EXPECT_FALSE(rtp_header2.extension.hasAbsoluteSendTime);
-  EXPECT_EQ(0u, rtp_header2.extension.absoluteSendTime);
-}
-
 TEST_F(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
   rtp_sender_.reset(new RTPSender(
       false, &fake_clock_, &transport_, nullptr,
       &seq_num_allocator_, &feedback_observer_, nullptr, nullptr, nullptr,
       &mock_rtc_event_log_, &send_packet_observer_,
       &retransmission_rate_limiter_));
   EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
                    kRtpExtensionTransportSequenceNumber,
                    kTransportSequenceNumberExtensionId));
 
@@ skipping 34 matching lines @@
                    kTransportSequenceNumberExtensionId));
   EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
       .WillOnce(testing::Return(kTransportSequenceNumber));
   EXPECT_CALL(send_packet_observer_,
               OnSendPacket(kTransportSequenceNumber, _, _))
       .Times(1);
 
   SendGenericPayload();
 }
 
-// Test CVO header extension is only set when marker bit is true.
-TEST_F(RtpSenderTestWithoutPacer, BuildRTPPacketWithVideoRotation_MarkerBit) {
-  rtp_sender_->SetVideoRotation(kRotation);
-  EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
-                   kRtpExtensionVideoRotation, kVideoRotationExtensionId));
-  EXPECT_TRUE(rtp_sender_->ActivateCVORtpHeaderExtension());
-
-  RtpHeaderExtensionMap map;
-  map.Register(kRtpExtensionVideoRotation, kVideoRotationExtensionId);
-
-  size_t length = static_cast<size_t>(
-      rtp_sender_->BuildRtpHeader(packet_, kPayload, true, kTimestamp, 0));
-  ASSERT_EQ(kRtpHeaderSize + rtp_sender_->RtpHeaderExtensionLength(), length);
-
-  // Verify
-  webrtc::RtpUtility::RtpHeaderParser rtp_parser(packet_, length);
-  webrtc::RTPHeader rtp_header;
-
-  ASSERT_TRUE(rtp_parser.Parse(&rtp_header, &map));
-  ASSERT_FALSE(rtp_parser.RTCP());
-  VerifyRTPHeaderCommon(rtp_header);
-  EXPECT_EQ(length, rtp_header.headerLength);
-  EXPECT_TRUE(rtp_header.extension.hasVideoRotation);
-  EXPECT_EQ(kRotation, rtp_header.extension.videoRotation);
-}
-
-// Test CVO header extension is not set when marker bit is false.
-TEST_F(RtpSenderTestWithoutPacer,
-       DISABLED_BuildRTPPacketWithVideoRotation_NoMarkerBit) {
-  rtp_sender_->SetVideoRotation(kRotation);
-  EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
-                   kRtpExtensionVideoRotation, kVideoRotationExtensionId));
-  EXPECT_TRUE(rtp_sender_->ActivateCVORtpHeaderExtension());
-
-  RtpHeaderExtensionMap map;
-  map.Register(kRtpExtensionVideoRotation, kVideoRotationExtensionId);
-
-  size_t length = static_cast<size_t>(
-      rtp_sender_->BuildRtpHeader(packet_, kPayload, false, kTimestamp, 0));
-  ASSERT_EQ(kRtpHeaderSize, length);
-
-  // Verify
-  webrtc::RtpUtility::RtpHeaderParser rtp_parser(packet_, length);
-  webrtc::RTPHeader rtp_header;
-
-  ASSERT_TRUE(rtp_parser.Parse(&rtp_header, &map));
-  ASSERT_FALSE(rtp_parser.RTCP());
-  VerifyRTPHeaderCommon(rtp_header, false);
-  EXPECT_EQ(length, rtp_header.headerLength);
-  EXPECT_FALSE(rtp_header.extension.hasVideoRotation);
-}
-
-TEST_F(RtpSenderTestWithoutPacer, BuildRTPPacketWithAudioLevelExtension) {
-  EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
-                                                       kAudioLevelExtensionId));
-
-  size_t length = static_cast<size_t>(rtp_sender_->BuildRtpHeader(
-      packet_, kPayload, kMarkerBit, kTimestamp, 0));
-  ASSERT_EQ(kRtpHeaderSize + rtp_sender_->RtpHeaderExtensionLength(), length);
-
-  // Verify
-  webrtc::RtpUtility::RtpHeaderParser rtp_parser(packet_, length);
-  webrtc::RTPHeader rtp_header;
-
-  // Updating audio level is done in RTPSenderAudio, so simulate it here.
-  rtp_parser.Parse(&rtp_header);
-  rtp_sender_->UpdateAudioLevel(packet_, length, rtp_header, true, kAudioLevel);
-
-  RtpHeaderExtensionMap map;
-  map.Register(kRtpExtensionAudioLevel, kAudioLevelExtensionId);
-  const bool valid_rtp_header = rtp_parser.Parse(&rtp_header, &map);
-
-  ASSERT_TRUE(valid_rtp_header);
-  ASSERT_FALSE(rtp_parser.RTCP());
-  VerifyRTPHeaderCommon(rtp_header);
-  EXPECT_EQ(length, rtp_header.headerLength);
-  EXPECT_TRUE(rtp_header.extension.hasAudioLevel);
-  EXPECT_TRUE(rtp_header.extension.voiceActivity);
-  EXPECT_EQ(kAudioLevel, rtp_header.extension.audioLevel);
-
-  // Parse without map extension
-  webrtc::RTPHeader rtp_header2;
-  const bool valid_rtp_header2 = rtp_parser.Parse(&rtp_header2, nullptr);
-
-  ASSERT_TRUE(valid_rtp_header2);
-  VerifyRTPHeaderCommon(rtp_header2);
-  EXPECT_EQ(length, rtp_header2.headerLength);
-  EXPECT_FALSE(rtp_header2.extension.hasAudioLevel);
-  EXPECT_FALSE(rtp_header2.extension.voiceActivity);
-  EXPECT_EQ(0u, rtp_header2.extension.audioLevel);
-}
-
-TEST_F(RtpSenderTestWithoutPacer,
-       BuildRTPPacketWithCSRCAndAudioLevelExtension) {
-  EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
-                                                       kAudioLevelExtensionId));
-  std::vector<uint32_t> csrcs;
-  csrcs.push_back(0x23456789);
-  rtp_sender_->SetCsrcs(csrcs);
-  size_t length = static_cast<size_t>(rtp_sender_->BuildRtpHeader(
-      packet_, kPayload, kMarkerBit, kTimestamp, 0));
-
-  // Verify
-  webrtc::RtpUtility::RtpHeaderParser rtp_parser(packet_, length);
-  webrtc::RTPHeader rtp_header;
-
-  // Updating audio level is done in RTPSenderAudio, so simulate it here.
-  rtp_parser.Parse(&rtp_header);
-  EXPECT_TRUE(rtp_sender_->UpdateAudioLevel(packet_, length, rtp_header, true,
-                                            kAudioLevel));
-
-  RtpHeaderExtensionMap map;
-  map.Register(kRtpExtensionAudioLevel, kAudioLevelExtensionId);
-  const bool valid_rtp_header = rtp_parser.Parse(&rtp_header, &map);
-
-  ASSERT_TRUE(valid_rtp_header);
-  ASSERT_FALSE(rtp_parser.RTCP());
-  VerifyRTPHeaderCommon(rtp_header, kMarkerBit, csrcs.size());
-  EXPECT_EQ(length, rtp_header.headerLength);
-  EXPECT_TRUE(rtp_header.extension.hasAudioLevel);
-  EXPECT_TRUE(rtp_header.extension.voiceActivity);
-  EXPECT_EQ(kAudioLevel, rtp_header.extension.audioLevel);
-  EXPECT_EQ(1u, rtp_header.numCSRCs);
-  EXPECT_EQ(csrcs[0], rtp_header.arrOfCSRCs[0]);
-}
-
-TEST_F(RtpSenderTestWithoutPacer, BuildRTPPacketWithHeaderExtensions) {
-  EXPECT_EQ(0, rtp_sender_->SetTransmissionTimeOffset(kTimeOffset));
-  EXPECT_EQ(0, rtp_sender_->SetAbsoluteSendTime(kAbsoluteSendTime));
-  EXPECT_EQ(0,
-            rtp_sender_->SetTransportSequenceNumber(kTransportSequenceNumber));
-  EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
-                   kRtpExtensionTransmissionTimeOffset,
-                   kTransmissionTimeOffsetExtensionId));
-  EXPECT_EQ(
-      0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
-                                                 kAbsoluteSendTimeExtensionId));
-  EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
-                                                       kAudioLevelExtensionId));
-  EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
-                   kRtpExtensionTransportSequenceNumber,
-                   kTransportSequenceNumberExtensionId));
-
-  size_t length = static_cast<size_t>(rtp_sender_->BuildRtpHeader(
-      packet_, kPayload, kMarkerBit, kTimestamp, 0));
-  ASSERT_EQ(kRtpHeaderSize + rtp_sender_->RtpHeaderExtensionLength(), length);
-
-  // Verify
-  webrtc::RtpUtility::RtpHeaderParser rtp_parser(packet_, length);
-  webrtc::RTPHeader rtp_header;
-
-  // Updating audio level is done in RTPSenderAudio, so simulate it here.
-  rtp_parser.Parse(&rtp_header);
-  rtp_sender_->UpdateAudioLevel(packet_, length, rtp_header, true, kAudioLevel);
-
-  RtpHeaderExtensionMap map;
-  map.Register(kRtpExtensionTransmissionTimeOffset,
-               kTransmissionTimeOffsetExtensionId);
-  map.Register(kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId);
-  map.Register(kRtpExtensionAudioLevel, kAudioLevelExtensionId);
-  map.Register(kRtpExtensionTransportSequenceNumber,
-               kTransportSequenceNumberExtensionId);
-  const bool valid_rtp_header = rtp_parser.Parse(&rtp_header, &map);
-
-  ASSERT_TRUE(valid_rtp_header);
-  ASSERT_FALSE(rtp_parser.RTCP());
-  VerifyRTPHeaderCommon(rtp_header);
-  EXPECT_EQ(length, rtp_header.headerLength);
-  EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset);
-  EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime);
-  EXPECT_TRUE(rtp_header.extension.hasAudioLevel);
-  EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber);
-  EXPECT_EQ(kTimeOffset, rtp_header.extension.transmissionTimeOffset);
-  EXPECT_EQ(kAbsoluteSendTime, rtp_header.extension.absoluteSendTime);
-  EXPECT_TRUE(rtp_header.extension.voiceActivity);
-  EXPECT_EQ(kAudioLevel, rtp_header.extension.audioLevel);
-  EXPECT_EQ(kTransportSequenceNumber,
-            rtp_header.extension.transportSequenceNumber);
-
-  // Parse without map extension
-  webrtc::RTPHeader rtp_header2;
-  const bool valid_rtp_header2 = rtp_parser.Parse(&rtp_header2, nullptr);
-
-  ASSERT_TRUE(valid_rtp_header2);
-  VerifyRTPHeaderCommon(rtp_header2);
-  EXPECT_EQ(length, rtp_header2.headerLength);
-  EXPECT_FALSE(rtp_header2.extension.hasTransmissionTimeOffset);
-  EXPECT_FALSE(rtp_header2.extension.hasAbsoluteSendTime);
-  EXPECT_FALSE(rtp_header2.extension.hasAudioLevel);
-  EXPECT_FALSE(rtp_header2.extension.hasTransportSequenceNumber);
-
-  EXPECT_EQ(0, rtp_header2.extension.transmissionTimeOffset);
-  EXPECT_EQ(0u, rtp_header2.extension.absoluteSendTime);
-  EXPECT_FALSE(rtp_header2.extension.voiceActivity);
-  EXPECT_EQ(0u, rtp_header2.extension.audioLevel);
-  EXPECT_EQ(0u, rtp_header2.extension.transportSequenceNumber);
-}
-
 TEST_F(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
   rtp_sender_.reset(new RTPSender(
       false, &fake_clock_, &transport_, &mock_paced_sender_,
       &seq_num_allocator_, &feedback_observer_, nullptr, nullptr, nullptr,
       &mock_rtc_event_log_, &send_packet_observer_,
       &retransmission_rate_limiter_));
   rtp_sender_->SetStorePacketsStatus(true, 10);
   EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
                    kRtpExtensionTransportSequenceNumber,
                    kTransportSequenceNumberExtensionId));
@@ skipping 38 matching lines @@
               LogRtpHeader(PacketDirection::kOutgoingPacket, _, _, _));
 
   rtp_sender_->SetStorePacketsStatus(true, 10);
   EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
                    kRtpExtensionTransmissionTimeOffset,
                    kTransmissionTimeOffsetExtensionId));
   EXPECT_EQ(
       0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
                                                  kAbsoluteSendTimeExtensionId));
   int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
-  int rtp_length_int = rtp_sender_->BuildRtpHeader(
-      packet_, kPayload, kMarkerBit, kTimestamp, capture_time_ms);
-  ASSERT_NE(-1, rtp_length_int);
-  size_t rtp_length = static_cast<size_t>(rtp_length_int);
+  auto packet =
+      BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
+  size_t packet_size = packet->size();
 
   // Packet should be stored in a send bucket.
-  EXPECT_TRUE(rtp_sender_->SendToNetwork(packet_, 0, rtp_length,
-                                         capture_time_ms, kAllowRetransmission,
+  EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
+                                         kAllowRetransmission,
                                          RtpPacketSender::kNormalPriority));
 
   EXPECT_EQ(0, transport_.packets_sent_);
 
   const int kStoredTimeInMs = 100;
   fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
 
   rtp_sender_->TimeToSendPacket(kSeqNum, capture_time_ms, false,
                                 PacketInfo::kNotAProbe);
 
   // Process send bucket. Packet should now be sent.
   EXPECT_EQ(1, transport_.packets_sent_);
-  EXPECT_EQ(rtp_length, transport_.last_sent_packet_len_);
+  EXPECT_EQ(packet_size, transport_.last_sent_packet_len_);
   // Parse sent packet.
   webrtc::RtpUtility::RtpHeaderParser rtp_parser(transport_.last_sent_packet_,
-                                                 rtp_length);
+                                                 packet_size);
   webrtc::RTPHeader rtp_header;
   RtpHeaderExtensionMap map;
   map.Register(kRtpExtensionTransmissionTimeOffset,
                kTransmissionTimeOffsetExtensionId);
   map.Register(kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId);
   const bool valid_rtp_header = rtp_parser.Parse(&rtp_header, &map);
   ASSERT_TRUE(valid_rtp_header);
 
   // Verify transmission time offset.
   EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
   uint64_t expected_send_time =
       ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
   EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
 }
 
 TEST_F(RtpSenderTest, TrafficSmoothingRetransmits) {
   EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
                                                _, kSeqNum, _, _, _));
   EXPECT_CALL(mock_rtc_event_log_,
               LogRtpHeader(PacketDirection::kOutgoingPacket, _, _, _));
 
   rtp_sender_->SetStorePacketsStatus(true, 10);
   EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
                    kRtpExtensionTransmissionTimeOffset,
                    kTransmissionTimeOffsetExtensionId));
   EXPECT_EQ(
       0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
                                                  kAbsoluteSendTimeExtensionId));
   int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
-  int rtp_length_int = rtp_sender_->BuildRtpHeader(
-      packet_, kPayload, kMarkerBit, kTimestamp, capture_time_ms);
-  ASSERT_NE(-1, rtp_length_int);
-  size_t rtp_length = static_cast<size_t>(rtp_length_int);
+  auto packet =
+      BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
+  size_t packet_size = packet->size();
 
   // Packet should be stored in a send bucket.
-  EXPECT_TRUE(rtp_sender_->SendToNetwork(packet_, 0, rtp_length,
-                                         capture_time_ms, kAllowRetransmission,
+  EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
+                                         kAllowRetransmission,
                                          RtpPacketSender::kNormalPriority));
 
   EXPECT_EQ(0, transport_.packets_sent_);
 
   EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
                                                _, kSeqNum, _, _, _));
 
   const int kStoredTimeInMs = 100;
   fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
 
-  EXPECT_EQ(rtp_length_int, rtp_sender_->ReSendPacket(kSeqNum));
+  EXPECT_EQ(static_cast<int>(packet_size), rtp_sender_->ReSendPacket(kSeqNum));
   EXPECT_EQ(0, transport_.packets_sent_);
 
   rtp_sender_->TimeToSendPacket(kSeqNum, capture_time_ms, false,
                                 PacketInfo::kNotAProbe);
 
   // Process send bucket. Packet should now be sent.
   EXPECT_EQ(1, transport_.packets_sent_);
-  EXPECT_EQ(rtp_length, transport_.last_sent_packet_len_);
+  EXPECT_EQ(packet_size, transport_.last_sent_packet_len_);
 
   // Parse sent packet.
   webrtc::RtpUtility::RtpHeaderParser rtp_parser(transport_.last_sent_packet_,
-                                                 rtp_length);
+                                                 packet_size);
   webrtc::RTPHeader rtp_header;
   RtpHeaderExtensionMap map;
   map.Register(kRtpExtensionTransmissionTimeOffset,
                kTransmissionTimeOffsetExtensionId);
   map.Register(kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId);
   const bool valid_rtp_header = rtp_parser.Parse(&rtp_header, &map);
   ASSERT_TRUE(valid_rtp_header);
 
   // Verify transmission time offset.
   EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
@@ skipping 30 matching lines @@
   std::unique_ptr<webrtc::RtpHeaderParser> rtp_parser(
       webrtc::RtpHeaderParser::Create());
   ASSERT_TRUE(rtp_parser.get() != nullptr);
   rtp_parser->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
                                          kTransmissionTimeOffsetExtensionId);
   rtp_parser->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
                                          kAbsoluteSendTimeExtensionId);
   webrtc::RTPHeader rtp_header;
 
   int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
-  int rtp_length_int = rtp_sender_->BuildRtpHeader(
-      packet_, kPayload, kMarkerBit, timestamp, capture_time_ms);
+  auto packet =
+      BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
   const uint32_t media_packet_timestamp = timestamp;
-  ASSERT_NE(-1, rtp_length_int);
-  size_t rtp_length = static_cast<size_t>(rtp_length_int);
+  size_t packet_size = packet->size();
 
   // Packet should be stored in a send bucket.
-  EXPECT_TRUE(rtp_sender_->SendToNetwork(packet_, 0, rtp_length,
-                                         capture_time_ms, kAllowRetransmission,
+  EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
+                                         kAllowRetransmission,
                                          RtpPacketSender::kNormalPriority));
 
   int total_packets_sent = 0;
   EXPECT_EQ(total_packets_sent, transport_.packets_sent_);
 
   const int kStoredTimeInMs = 100;
   fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
   rtp_sender_->TimeToSendPacket(seq_num++, capture_time_ms, false,
                                 PacketInfo::kNotAProbe);
   // Packet should now be sent. This test doesn't verify the regular video
@@ skipping 29 matching lines @@
     EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
     uint64_t expected_send_time =
         ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
     EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
     fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
     timestamp += 90 * kPaddingPeriodMs;
   }
 
   // Send a regular video packet again.
   capture_time_ms = fake_clock_.TimeInMilliseconds();
-  rtp_length_int = rtp_sender_->BuildRtpHeader(packet_, kPayload, kMarkerBit,
-                                               timestamp, capture_time_ms);
-  ASSERT_NE(-1, rtp_length_int);
-  rtp_length = static_cast<size_t>(rtp_length_int);
+  packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
+  packet_size = packet->size();
 
   EXPECT_CALL(mock_paced_sender_,
               InsertPacket(RtpPacketSender::kNormalPriority, _, _, _, _, _));
 
   // Packet should be stored in a send bucket.
-  EXPECT_TRUE(rtp_sender_->SendToNetwork(packet_, 0, rtp_length,
-                                         capture_time_ms, kAllowRetransmission,
+  EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
+                                         kAllowRetransmission,
                                          RtpPacketSender::kNormalPriority));
 
   rtp_sender_->TimeToSendPacket(seq_num, capture_time_ms, false,
                                 PacketInfo::kNotAProbe);
   // Process send bucket.
   EXPECT_EQ(++total_packets_sent, transport_.packets_sent_);
-  EXPECT_EQ(rtp_length, transport_.last_sent_packet_len_);
+  EXPECT_EQ(packet_size, transport_.last_sent_packet_len_);
   // Parse sent packet.
-  ASSERT_TRUE(
-      rtp_parser->Parse(transport_.last_sent_packet_, rtp_length, &rtp_header));
+  ASSERT_TRUE(rtp_parser->Parse(transport_.last_sent_packet_, packet_size,
+                                &rtp_header));
 
   // Verify sequence number and timestamp.
   EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
   EXPECT_EQ(timestamp, rtp_header.timestamp);
   // Verify transmission time offset. This packet is sent without delay.
   EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
   uint64_t expected_send_time =
       ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
   EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
 }
@@ skipping 618 matching lines @@
   // Must be at least 5ms in between retransmission attempts.
   fake_clock_.AdvanceTimeMilliseconds(5);
 
   // Resending should not work, bandwidth exceeded.
   rtp_sender_->OnReceivedNack(sequence_numbers, 0);
   EXPECT_EQ(kNumPackets * 2, transport_.packets_sent_);
 }
 
 // Verify that all packets of a frame have CVO byte set.
 TEST_F(RtpSenderVideoTest, SendVideoWithCVO) {
+  uint8_t kFrame[kMaxPacketLength];
   RTPVideoHeader hdr = {0};
   hdr.rotation = kVideoRotation_90;
 
   EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
                    kRtpExtensionVideoRotation, kVideoRotationExtensionId));
   EXPECT_TRUE(rtp_sender_->ActivateCVORtpHeaderExtension());
 
   EXPECT_EQ(
       RtpUtility::Word32Align(kRtpOneByteHeaderLength + kVideoRotationLength),
       rtp_sender_->RtpHeaderExtensionLength());
 
   rtp_sender_video_->SendVideo(kRtpVideoGeneric, kVideoFrameKey, kPayload,
-                               kTimestamp, 0, packet_, sizeof(packet_), nullptr,
+                               kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
                                &hdr);
 
   RtpHeaderExtensionMap map;
   map.Register(kRtpExtensionVideoRotation, kVideoRotationExtensionId);
 
   // Verify that this packet does have CVO byte.
   VerifyCVOPacket(
       reinterpret_cast<uint8_t*>(transport_.sent_packets_[0]->data()),
       transport_.sent_packets_[0]->size(), true, &map, kSeqNum, hdr.rotation);
 
@@ skipping 19 matching lines @@
             ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 0));
   EXPECT_EQ(kVideoRotation_90,
             ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 1));
   EXPECT_EQ(kVideoRotation_180,
             ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 2));
   EXPECT_EQ(kVideoRotation_270,
             ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 3));
 }
 
 }  // namespace webrtc