Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/modules/video_coding/codecs/vp8/vp8_impl.h

Issue 2398963003: Move usage of QualityScaler to ViEEncoder. (Closed)
Patch Set: Code review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm ('K') | « webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm ('k') | webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc » ('j') | webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/codecs/vp8/vp8_impl.h
diff --git a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.h b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.h
index 00a711554d5a5e367f7ebeccf8065d81731c2658..763e6eaad0a8969c540eb51c7319d088b480960f 100644
--- a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.h
+++ b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.h
@@ -27,7 +27,6 @@
#include "webrtc/modules/video_coding/include/video_codec_interface.h"
#include "webrtc/modules/video_coding/codecs/vp8/include/vp8.h"
#include "webrtc/modules/video_coding/codecs/vp8/reference_picture_selection.h"
-#include "webrtc/modules/video_coding/utility/quality_scaler.h"
#include "webrtc/video_frame.h"
namespace webrtc {
@@ -116,8 +115,6 @@ class VP8EncoderImpl : public VP8Encoder {
std::vector<vpx_codec_ctx_t> encoders_;
std::vector<vpx_codec_enc_cfg_t> configurations_;
std::vector<vpx_rational_t> downsampling_factors_;
- QualityScaler quality_scaler_;
- bool quality_scaler_enabled_;
magjed_webrtc 2016/10/07 12:02:54 ditto: We need to keep the quality_scaler_enabled_
}; // end of VP8EncoderImpl class
class VP8DecoderImpl : public VP8Decoder {
« webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm ('K') | « webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm ('k') | webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc » ('j') | webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698