Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: webrtc/modules/video_coding/codecs/vp8/vp8_impl.h

Issue 2398963003: Move usage of QualityScaler to ViEEncoder. (Closed)
Patch Set: Code review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 * 9 *
10 * WEBRTC VP8 wrapper interface 10 * WEBRTC VP8 wrapper interface
11 */ 11 */
12 12
13 #ifndef WEBRTC_MODULES_VIDEO_CODING_CODECS_VP8_VP8_IMPL_H_ 13 #ifndef WEBRTC_MODULES_VIDEO_CODING_CODECS_VP8_VP8_IMPL_H_
14 #define WEBRTC_MODULES_VIDEO_CODING_CODECS_VP8_VP8_IMPL_H_ 14 #define WEBRTC_MODULES_VIDEO_CODING_CODECS_VP8_VP8_IMPL_H_
15 15
16 #include <memory> 16 #include <memory>
17 #include <vector> 17 #include <vector>
18 18
19 // NOTE: This include order must remain to avoid compile errors, even though 19 // NOTE: This include order must remain to avoid compile errors, even though
20 // it breaks the style guide. 20 // it breaks the style guide.
21 #include "vpx/vpx_encoder.h" 21 #include "vpx/vpx_encoder.h"
22 #include "vpx/vpx_decoder.h" 22 #include "vpx/vpx_decoder.h"
23 #include "vpx/vp8cx.h" 23 #include "vpx/vp8cx.h"
24 #include "vpx/vp8dx.h" 24 #include "vpx/vp8dx.h"
25 25
26 #include "webrtc/common_video/include/i420_buffer_pool.h" 26 #include "webrtc/common_video/include/i420_buffer_pool.h"
27 #include "webrtc/modules/video_coding/include/video_codec_interface.h" 27 #include "webrtc/modules/video_coding/include/video_codec_interface.h"
28 #include "webrtc/modules/video_coding/codecs/vp8/include/vp8.h" 28 #include "webrtc/modules/video_coding/codecs/vp8/include/vp8.h"
29 #include "webrtc/modules/video_coding/codecs/vp8/reference_picture_selection.h" 29 #include "webrtc/modules/video_coding/codecs/vp8/reference_picture_selection.h"
30 #include "webrtc/modules/video_coding/utility/quality_scaler.h"
31 #include "webrtc/video_frame.h" 30 #include "webrtc/video_frame.h"
32 31
33 namespace webrtc { 32 namespace webrtc {
34 33
35 class SimulcastRateAllocator; 34 class SimulcastRateAllocator;
36 class TemporalLayers; 35 class TemporalLayers;
37 36
38 class VP8EncoderImpl : public VP8Encoder { 37 class VP8EncoderImpl : public VP8Encoder {
39 public: 38 public:
40 VP8EncoderImpl(); 39 VP8EncoderImpl();
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 std::vector<uint16_t> picture_id_; 108 std::vector<uint16_t> picture_id_;
110 std::vector<int> last_key_frame_picture_id_; 109 std::vector<int> last_key_frame_picture_id_;
111 std::vector<bool> key_frame_request_; 110 std::vector<bool> key_frame_request_;
112 std::vector<bool> send_stream_; 111 std::vector<bool> send_stream_;
113 std::vector<int> cpu_speed_; 112 std::vector<int> cpu_speed_;
114 std::vector<vpx_image_t> raw_images_; 113 std::vector<vpx_image_t> raw_images_;
115 std::vector<EncodedImage> encoded_images_; 114 std::vector<EncodedImage> encoded_images_;
116 std::vector<vpx_codec_ctx_t> encoders_; 115 std::vector<vpx_codec_ctx_t> encoders_;
117 std::vector<vpx_codec_enc_cfg_t> configurations_; 116 std::vector<vpx_codec_enc_cfg_t> configurations_;
118 std::vector<vpx_rational_t> downsampling_factors_; 117 std::vector<vpx_rational_t> downsampling_factors_;
119 QualityScaler quality_scaler_;
120 bool quality_scaler_enabled_;
magjed_webrtc 2016/10/07 12:02:54 ditto: We need to keep the quality_scaler_enabled_
121 }; // end of VP8EncoderImpl class 118 }; // end of VP8EncoderImpl class
122 119
123 class VP8DecoderImpl : public VP8Decoder { 120 class VP8DecoderImpl : public VP8Decoder {
124 public: 121 public:
125 VP8DecoderImpl(); 122 VP8DecoderImpl();
126 123
127 virtual ~VP8DecoderImpl(); 124 virtual ~VP8DecoderImpl();
128 125
129 int InitDecode(const VideoCodec* inst, int number_of_cores) override; 126 int InitDecode(const VideoCodec* inst, int number_of_cores) override;
130 127
(...skipping 30 matching lines...) Expand all
161 int image_format_; 158 int image_format_;
162 vpx_ref_frame_t* ref_frame_; 159 vpx_ref_frame_t* ref_frame_;
163 int propagation_cnt_; 160 int propagation_cnt_;
164 int last_frame_width_; 161 int last_frame_width_;
165 int last_frame_height_; 162 int last_frame_height_;
166 bool key_frame_required_; 163 bool key_frame_required_;
167 }; // end of VP8DecoderImpl class 164 }; // end of VP8DecoderImpl class
168 } // namespace webrtc 165 } // namespace webrtc
169 166
170 #endif // WEBRTC_MODULES_VIDEO_CODING_CODECS_VP8_VP8_IMPL_H_ 167 #endif // WEBRTC_MODULES_VIDEO_CODING_CODECS_VP8_VP8_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698