Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 2394253003: Revert of Made MixerAudioSource a pure interface. (Closed)

Created:
4 years, 2 months ago by aleloi
Modified:
4 years, 2 months ago
Reviewers:
the sun, ivoc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Made MixerAudioSource a pure interface. (patchset #7 id:350001 of https://codereview.webrtc.org/2396483002/ ) Reason for revert: breaks chromium FYI Original issue's description: > Made MixerAudioSource a pure interface. > > This required quite a few small changes in the mixing algorithm > structure, the mixer interface and the mixer unit tests. > > BUG=webrtc:6346 > > Committed: https://crrev.com/2ae5fdff86b784545cbd724de54bb5ffedde1adf > Cr-Commit-Position: refs/heads/master@{#14567} TBR=ivoc@webrtc.org,solenberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6346 Committed: https://crrev.com/a485dabc7869c35c7d5a8a377e518603012ffa48 Cr-Commit-Position: refs/heads/master@{#14568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -215 lines) Patch
M webrtc/modules/audio_mixer/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_mixer/audio_frame_manipulator.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_mixer/audio_frame_manipulator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_mixer/audio_mixer.gypi View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_mixer/audio_mixer_defines.h View 2 chunks +19 lines, -2 lines 0 comments Download
A webrtc/modules/audio_mixer/audio_mixer_defines.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M webrtc/modules/audio_mixer/audio_mixer_impl.h View 4 chunks +9 lines, -10 lines 0 comments Download
M webrtc/modules/audio_mixer/audio_mixer_impl.cc View 17 chunks +80 lines, -95 lines 0 comments Download
D webrtc/modules/audio_mixer/audio_source_with_mix_status.h View 1 chunk +0 lines, -45 lines 0 comments Download
D webrtc/modules/audio_mixer/audio_source_with_mix_status.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M webrtc/modules/audio_mixer/test/audio_mixer_unittest.cc View 8 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
aleloi
Created Revert of Made MixerAudioSource a pure interface.
4 years, 2 months ago (2016-10-07 12:04:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2394253003/1
4 years, 2 months ago (2016-10-07 12:04:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 12:04:55 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 12:05:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a485dabc7869c35c7d5a8a377e518603012ffa48
Cr-Commit-Position: refs/heads/master@{#14568}

Powered by Google App Engine
This is Rietveld 408576698