Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: webrtc/modules/audio_mixer/audio_mixer_impl.h

Issue 2394253003: Revert of Made MixerAudioSource a pure interface. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_AUDIO_MIXER_AUDIO_MIXER_IMPL_H_ 11 #ifndef WEBRTC_MODULES_AUDIO_MIXER_AUDIO_MIXER_IMPL_H_
12 #define WEBRTC_MODULES_AUDIO_MIXER_AUDIO_MIXER_IMPL_H_ 12 #define WEBRTC_MODULES_AUDIO_MIXER_AUDIO_MIXER_IMPL_H_
13 13
14 #include <map> 14 #include <map>
15 #include <memory> 15 #include <memory>
16 #include <vector> 16 #include <vector>
17 17
18 #include "webrtc/base/thread_annotations.h" 18 #include "webrtc/base/thread_annotations.h"
19 #include "webrtc/base/thread_checker.h" 19 #include "webrtc/base/thread_checker.h"
20 #include "webrtc/modules/audio_mixer/audio_mixer.h" 20 #include "webrtc/modules/audio_mixer/audio_mixer.h"
21 #include "webrtc/modules/audio_mixer/audio_mixer_defines.h" 21 #include "webrtc/modules/audio_mixer/audio_mixer_defines.h"
22 #include "webrtc/modules/audio_mixer/audio_source_with_mix_status.h"
23 #include "webrtc/modules/audio_processing/include/audio_processing.h" 22 #include "webrtc/modules/audio_processing/include/audio_processing.h"
24 #include "webrtc/modules/include/module_common_types.h" 23 #include "webrtc/modules/include/module_common_types.h"
25 #include "webrtc/system_wrappers/include/critical_section_wrapper.h" 24 #include "webrtc/system_wrappers/include/critical_section_wrapper.h"
26 #include "webrtc/voice_engine/level_indicator.h" 25 #include "webrtc/voice_engine/level_indicator.h"
27 #include "webrtc/voice_engine_configurations.h" 26 #include "webrtc/voice_engine_configurations.h"
28 27
29 namespace webrtc { 28 namespace webrtc {
30 29
31 typedef std::vector<AudioFrame*> AudioFrameList; 30 typedef std::vector<AudioFrame*> AudioFrameList;
32 typedef std::vector<AudioSourceWithMixStatus> MixerAudioSourceList; 31 typedef std::vector<MixerAudioSource*> MixerAudioSourceList;
33 32
34 class AudioMixerImpl : public AudioMixer { 33 class AudioMixerImpl : public AudioMixer {
35 public: 34 public:
36 // AudioProcessing only accepts 10 ms frames. 35 // AudioProcessing only accepts 10 ms frames.
37 static const int kFrameDurationInMs = 10; 36 static const int kFrameDurationInMs = 10;
38 37
39 static std::unique_ptr<AudioMixerImpl> Create(int id); 38 static std::unique_ptr<AudioMixer> Create(int id);
40 39
41 ~AudioMixerImpl() override; 40 ~AudioMixerImpl() override;
42 41
43 // AudioMixer functions 42 // AudioMixer functions
44 int32_t SetMixabilityStatus(MixerAudioSource* audio_source, 43 int32_t SetMixabilityStatus(MixerAudioSource* audio_source,
45 bool mixable) override; 44 bool mixable) override;
46 bool MixabilityStatus(const MixerAudioSource& audio_source) const override; 45 bool MixabilityStatus(const MixerAudioSource& audio_source) const override;
47 int32_t SetAnonymousMixabilityStatus(MixerAudioSource* audio_source, 46 int32_t SetAnonymousMixabilityStatus(MixerAudioSource* audio_source,
48 bool mixable) override; 47 bool mixable) override;
49 void Mix(int sample_rate, 48 void Mix(int sample_rate,
50 size_t number_of_channels, 49 size_t number_of_channels,
51 AudioFrame* audio_frame_for_mixing) override; 50 AudioFrame* audio_frame_for_mixing) override;
52 bool AnonymousMixabilityStatus( 51 bool AnonymousMixabilityStatus(
53 const MixerAudioSource& audio_source) const override; 52 const MixerAudioSource& audio_source) const override;
54 53
55 // Returns true if the source was mixed last round. Returns
56 // false and logs an error if the source was never added to the
57 // mixer.
58 bool GetAudioSourceMixabilityStatusForTest(MixerAudioSource* audio_source);
59
60 private: 54 private:
61 AudioMixerImpl(int id, std::unique_ptr<AudioProcessing> limiter); 55 AudioMixerImpl(int id, std::unique_ptr<AudioProcessing> limiter);
62 56
63 // Set/get mix frequency 57 // Set/get mix frequency
64 int32_t SetOutputFrequency(const Frequency& frequency); 58 int32_t SetOutputFrequency(const Frequency& frequency);
65 Frequency OutputFrequency() const; 59 Frequency OutputFrequency() const;
66 60
67 // Compute what audio sources to mix from audio_source_list_. Ramp 61 // Compute what audio sources to mix from audio_source_list_. Ramp
68 // in and out. Update mixed status. Mixes up to 62 // in and out. Update mixed status. Mixes up to
69 // kMaximumAmountOfMixedAudioSources audio sources. 63 // kMaximumAmountOfMixedAudioSources audio sources.
70 AudioFrameList GetNonAnonymousAudio() EXCLUSIVE_LOCKS_REQUIRED(crit_); 64 AudioFrameList GetNonAnonymousAudio() const EXCLUSIVE_LOCKS_REQUIRED(crit_);
71 65
72 // Return the AudioFrames that should be mixed anonymously. Ramp in 66 // Return the AudioFrames that should be mixed anonymously. Ramp in
73 // and out. Update mixed status. 67 // and out. Update mixed status.
74 AudioFrameList GetAnonymousAudio() EXCLUSIVE_LOCKS_REQUIRED(crit_); 68 AudioFrameList GetAnonymousAudio() const EXCLUSIVE_LOCKS_REQUIRED(crit_);
69
70 // This function returns true if it finds the MixerAudioSource in the
71 // specified list of MixerAudioSources.
72 bool IsAudioSourceInList(const MixerAudioSource& audio_source,
73 const MixerAudioSourceList& audio_source_list) const;
75 74
76 // Add/remove the MixerAudioSource to the specified 75 // Add/remove the MixerAudioSource to the specified
77 // MixerAudioSource list. 76 // MixerAudioSource list.
78 bool AddAudioSourceToList(MixerAudioSource* audio_source, 77 bool AddAudioSourceToList(MixerAudioSource* audio_source,
79 MixerAudioSourceList* audio_source_list) const; 78 MixerAudioSourceList* audio_source_list) const;
80 bool RemoveAudioSourceFromList(MixerAudioSource* remove_audio_source, 79 bool RemoveAudioSourceFromList(MixerAudioSource* remove_audio_source,
81 MixerAudioSourceList* audio_source_list) const; 80 MixerAudioSourceList* audio_source_list) const;
82 81
83 bool LimitMixedAudio(AudioFrame* mixed_audio) const; 82 bool LimitMixedAudio(AudioFrame* mixed_audio) const;
84 83
(...skipping 30 matching lines...) Expand all
115 std::unique_ptr<AudioProcessing> limiter_ ACCESS_ON(&thread_checker_); 114 std::unique_ptr<AudioProcessing> limiter_ ACCESS_ON(&thread_checker_);
116 115
117 // Measures audio level for the combined signal. 116 // Measures audio level for the combined signal.
118 voe::AudioLevel audio_level_ ACCESS_ON(&thread_checker_); 117 voe::AudioLevel audio_level_ ACCESS_ON(&thread_checker_);
119 118
120 RTC_DISALLOW_COPY_AND_ASSIGN(AudioMixerImpl); 119 RTC_DISALLOW_COPY_AND_ASSIGN(AudioMixerImpl);
121 }; 120 };
122 } // namespace webrtc 121 } // namespace webrtc
123 122
124 #endif // WEBRTC_MODULES_AUDIO_MIXER_AUDIO_MIXER_IMPL_H_ 123 #endif // WEBRTC_MODULES_AUDIO_MIXER_AUDIO_MIXER_IMPL_H_
OLDNEW
« no previous file with comments | « webrtc/modules/audio_mixer/audio_mixer_defines.cc ('k') | webrtc/modules/audio_mixer/audio_mixer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698