Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2393723004: replace NtpTime->Clock with Clock->NtpTime dependency (Closed)

Created:
4 years, 2 months ago by danilchap
Modified:
3 years, 10 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, danilchap, zhuangzesen_agora.io, henrika_webrtc, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

replace NtpTime->Clock with Clock->NtpTime dependency BUG=None Review-Url: https://codereview.webrtc.org/2393723004 Cr-Commit-Position: refs/heads/master@{#16519} Committed: https://chromium.googlesource.com/external/webrtc/+/3795376ba1a0292d594859ae7826e2ca4d5f1a2c

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : Added TODO #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -47 lines) Patch
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/time_util.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/system_wrappers/include/clock.h View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download
M webrtc/system_wrappers/include/ntp_time.h View 1 2 chunks +6 lines, -10 lines 0 comments Download
M webrtc/system_wrappers/source/clock.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M webrtc/system_wrappers/source/ntp_time_unittest.cc View 1 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
danilchap
3 years, 10 months ago (2017-02-09 16:12:30 UTC) #5
perkj_webrtc
lgtm % with a request. https://codereview.webrtc.org/2393723004/diff/80001/webrtc/system_wrappers/include/clock.h File webrtc/system_wrappers/include/clock.h (right): https://codereview.webrtc.org/2393723004/diff/80001/webrtc/system_wrappers/include/clock.h#newcode47 webrtc/system_wrappers/include/clock.h:47: NtpTime CurrentNtpTime() const; please ...
3 years, 10 months ago (2017-02-09 17:55:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2393723004/120001
3 years, 10 months ago (2017-02-09 18:17:31 UTC) #13
danilchap
https://codereview.webrtc.org/2393723004/diff/80001/webrtc/system_wrappers/include/clock.h File webrtc/system_wrappers/include/clock.h (right): https://codereview.webrtc.org/2393723004/diff/80001/webrtc/system_wrappers/include/clock.h#newcode47 webrtc/system_wrappers/include/clock.h:47: NtpTime CurrentNtpTime() const; On 2017/02/09 17:55:22, perkj_webrtc wrote: > ...
3 years, 10 months ago (2017-02-09 18:17:32 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 19:15:30 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:120001) as
https://chromium.googlesource.com/external/webrtc/+/3795376ba1a0292d594859ae7...

Powered by Google App Engine
This is Rietveld 408576698