Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2391563002:
Increase the threshold for RunPlayoutAndRecordingInFullDuplex. (Closed)
|
Created:
4 years, 2 months ago by ehmaldonado_webrtc Modified:
4 years, 2 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionIncrease the threshold for RunPlayoutAndRecordingInFullDuplex.
RunPlayoutAndRecordingInFullDuplex fails sometimes on Android swarming
bots, presumably because the timing is hardware dependent.
This test ensures that audio starts pumping. The exact performance is
not that important.
R=kjellander@webrtc.org, henrika@webrtc.org
BUG=webrtc:6464
NOTRY=True
Committed: https://crrev.com/ebb0b8ec9a669c050b27cde5ef0779f5ad39ba76
Cr-Commit-Position: refs/heads/master@{#14492}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Added comment. #
Total comments: 1
Patch Set 3 : Nits. #Messages
Total messages: 18 (8 generated)
https://codereview.webrtc.org/2391563002/diff/1/webrtc/modules/audio_device/a... File webrtc/modules/audio_device/android/audio_device_unittest.cc (right): https://codereview.webrtc.org/2391563002/diff/1/webrtc/modules/audio_device/a... webrtc/modules/audio_device/android/audio_device_unittest.cc:1023: EXPECT_LE(fifo_audio_stream->average_size(), 30u); Can you add a reference to this issue here explaining why we had to set a rather high value.
On 2016/10/03 14:32:45, henrika_webrtc wrote: > https://codereview.webrtc.org/2391563002/diff/1/webrtc/modules/audio_device/a... > File webrtc/modules/audio_device/android/audio_device_unittest.cc (right): > > https://codereview.webrtc.org/2391563002/diff/1/webrtc/modules/audio_device/a... > webrtc/modules/audio_device/android/audio_device_unittest.cc:1023: > EXPECT_LE(fifo_audio_stream->average_size(), 30u); > Can you add a reference to this issue here explaining why we had to set a rather > high value. PTAL
LGTM https://codereview.webrtc.org/2391563002/diff/20001/webrtc/modules/audio_devi... File webrtc/modules/audio_device/android/audio_device_unittest.cc (right): https://codereview.webrtc.org/2391563002/diff/20001/webrtc/modules/audio_devi... webrtc/modules/audio_device/android/audio_device_unittest.cc:1024: // This threshold are set particularly high to accomodate differences in Nit. These thresholds are set rather high .... And http://bugs.webrtc.org/6464.
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by ehmaldonado@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from henrika@webrtc.org Link to the patchset: https://codereview.webrtc.org/2391563002/#ps60001 (title: "Nits.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/18268)
Description was changed from ========== Increase the threshold for RunPlayoutAndRecordingInFullDuplex. RunPlayoutAndRecordingInFullDuplex fails sometimes on Android swarming bots, presumably because the timing is hardware dependent. This test ensures that audio starts pumping. The exact performance is not that important. R=kjellander@webrtc.org, henrika@webrtc.org BUG=webrtc:6464 ========== to ========== Increase the threshold for RunPlayoutAndRecordingInFullDuplex. RunPlayoutAndRecordingInFullDuplex fails sometimes on Android swarming bots, presumably because the timing is hardware dependent. This test ensures that audio starts pumping. The exact performance is not that important. R=kjellander@webrtc.org, henrika@webrtc.org BUG=webrtc:6464 NOTRY=True ==========
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Increase the threshold for RunPlayoutAndRecordingInFullDuplex. RunPlayoutAndRecordingInFullDuplex fails sometimes on Android swarming bots, presumably because the timing is hardware dependent. This test ensures that audio starts pumping. The exact performance is not that important. R=kjellander@webrtc.org, henrika@webrtc.org BUG=webrtc:6464 NOTRY=True ========== to ========== Increase the threshold for RunPlayoutAndRecordingInFullDuplex. RunPlayoutAndRecordingInFullDuplex fails sometimes on Android swarming bots, presumably because the timing is hardware dependent. This test ensures that audio starts pumping. The exact performance is not that important. R=kjellander@webrtc.org, henrika@webrtc.org BUG=webrtc:6464 NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Increase the threshold for RunPlayoutAndRecordingInFullDuplex. RunPlayoutAndRecordingInFullDuplex fails sometimes on Android swarming bots, presumably because the timing is hardware dependent. This test ensures that audio starts pumping. The exact performance is not that important. R=kjellander@webrtc.org, henrika@webrtc.org BUG=webrtc:6464 NOTRY=True ========== to ========== Increase the threshold for RunPlayoutAndRecordingInFullDuplex. RunPlayoutAndRecordingInFullDuplex fails sometimes on Android swarming bots, presumably because the timing is hardware dependent. This test ensures that audio starts pumping. The exact performance is not that important. R=kjellander@webrtc.org, henrika@webrtc.org BUG=webrtc:6464 NOTRY=True Committed: https://crrev.com/ebb0b8ec9a669c050b27cde5ef0779f5ad39ba76 Cr-Commit-Position: refs/heads/master@{#14492} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/ebb0b8ec9a669c050b27cde5ef0779f5ad39ba76 Cr-Commit-Position: refs/heads/master@{#14492} |
