Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Unified Diff: webrtc/modules/audio_device/android/audio_device_unittest.cc

Issue 2391563002: Increase the threshold for RunPlayoutAndRecordingInFullDuplex. (Closed)
Patch Set: Nits. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_device/android/audio_device_unittest.cc
diff --git a/webrtc/modules/audio_device/android/audio_device_unittest.cc b/webrtc/modules/audio_device/android/audio_device_unittest.cc
index 56fb209d0253d09d192a346ac72fea3841b3f1f8..eefab0f4e1ca557db04785dc4540538d51f08207 100644
--- a/webrtc/modules/audio_device/android/audio_device_unittest.cc
+++ b/webrtc/modules/audio_device/android/audio_device_unittest.cc
@@ -1020,8 +1020,12 @@ TEST_F(AudioDeviceTest, RunPlayoutAndRecordingInFullDuplex) {
1000 * kFullDuplexTimeInSec));
StopPlayout();
StopRecording();
- EXPECT_LE(fifo_audio_stream->average_size(), 10u);
- EXPECT_LE(fifo_audio_stream->largest_size(), 20u);
+
+ // These thresholds are set rather high to accomodate differences in hardware
+ // in several devices, so this test can be used in swarming.
+ // See http://bugs.webrtc.org/6464
+ EXPECT_LE(fifo_audio_stream->average_size(), 30u);
+ EXPECT_LE(fifo_audio_stream->largest_size(), 40u);
}
// Measures loopback latency and reports the min, max and average values for
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698