Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 2387113008: Fix some chromium style warnings in remote_bitrate_estimator.h (Closed)

Created:
4 years, 2 months ago by terelius
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix some chromium style warnings in remote_bitrate_estimator.h BUG=webrtc:163 Committed: https://crrev.com/c22bcf4f4bed1f05b5e59127f93b58129cd2627f Cr-Commit-Position: refs/heads/master@{#14737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h View 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
terelius
PTAL
4 years, 2 months ago (2016-10-07 13:28:15 UTC) #2
stefan-webrtc
lgtm
4 years, 2 months ago (2016-10-07 13:38:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2387113008/1
4 years, 2 months ago (2016-10-19 15:27:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on ...
4 years, 2 months ago (2016-10-19 17:27:58 UTC) #8
kjellander_webrtc
On 2016/10/19 17:27:58, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 2 months ago (2016-10-19 19:33:15 UTC) #9
kjellander_webrtc
lgtm
4 years, 2 months ago (2016-10-19 19:33:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2387113008/1
4 years, 2 months ago (2016-10-21 12:22:06 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on ...
4 years, 2 months ago (2016-10-21 14:22:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2387113008/1
4 years, 2 months ago (2016-10-24 08:41:25 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-24 09:57:08 UTC) #18
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c22bcf4f4bed1f05b5e59127f93b58129cd2627f Cr-Commit-Position: refs/heads/master@{#14737}
4 years, 2 months ago (2016-10-24 09:57:20 UTC) #20
terelius
4 years, 1 month ago (2016-10-24 13:43:16 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2444923002/ by terelius@webrtc.org.

The reason for reverting is: Broke internal project..

Powered by Google App Engine
This is Rietveld 408576698