Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h

Issue 2387113008: Fix some chromium style warnings in remote_bitrate_estimator.h (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h
diff --git a/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h b/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h
index dfeedfce853ac542d22ff89b970f19ed36bca232..c7f1ffa46d3a40ef7d51500fe63688ca8492c796 100644
--- a/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h
+++ b/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h
@@ -45,12 +45,10 @@ struct ReceiveBandwidthEstimatorStats {};
class RemoteBitrateEstimator : public CallStatsObserver, public Module {
public:
static const int kDefaultMinBitrateBps = 30000;
- virtual ~RemoteBitrateEstimator() {}
+ ~RemoteBitrateEstimator() override {}
virtual void IncomingPacketFeedbackVector(
- const std::vector<PacketInfo>& packet_feedback_vector) {
- assert(false);
- }
+ const std::vector<PacketInfo>& packet_feedback_vector) = 0;
// Called for each incoming packet. Updates the incoming payload bitrate
// estimate and the over-use detector. If an over-use is detected the

Powered by Google App Engine
This is Rietveld 408576698