Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2385553003: Delete left-over SignalRenderFrame signal. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 2 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete left-over SignalRenderFrame signal. Unused and unneeded since https://codereview.webrtc.org/1819103003. BUG=webrtc:5426 Committed: https://crrev.com/e643c59333651d1d05f0ba28f445059b0d8de30d Cr-Commit-Position: refs/heads/master@{#14515}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M webrtc/media/base/fakevideorenderer.h View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
nisse-webrtc
4 years, 2 months ago (2016-09-30 13:15:07 UTC) #2
perkj_webrtc
lgtm if no tests use the sigslots
4 years, 2 months ago (2016-10-03 05:55:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2385553003/1
4 years, 2 months ago (2016-10-03 06:22:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_msan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/13609)
4 years, 2 months ago (2016-10-03 07:14:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2385553003/1
4 years, 2 months ago (2016-10-04 07:32:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_clang_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_clang_rel/builds/6929)
4 years, 2 months ago (2016-10-04 09:00:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2385553003/1
4 years, 2 months ago (2016-10-05 06:18:49 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 07:13:59 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 07:14:09 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e643c59333651d1d05f0ba28f445059b0d8de30d
Cr-Commit-Position: refs/heads/master@{#14515}

Powered by Google App Engine
This is Rietveld 408576698