webrtc/base/thread_checker_unittest.cc - Issue 2384693002: Test RTC_DCHECK_IS_ON instead of checking DCHECK_ALWAYS_ON everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/thread_checker_unittest.cc

Issue 2384693002: Test RTC_DCHECK_IS_ON instead of checking DCHECK_ALWAYS_ON everywhere (Closed)

Patch Set: !!! Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/base/thread_checker_unittest.cc

diff --git a/webrtc/base/thread_checker_unittest.cc b/webrtc/base/thread_checker_unittest.cc

index 2e6afe947beffc16630d88bc90d99b3cb5b69138..811916df71979858b306afdce40175400065c931 100644

--- a/webrtc/base/thread_checker_unittest.cc

+++ b/webrtc/base/thread_checker_unittest.cc

@@ -21,11 +21,7 @@

// Duplicated from base/threading/thread_checker.h so that we can be

// good citizens there and undef the macro.

-#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)

-#define ENABLE_THREAD_CHECKER 1

-#else

-#define ENABLE_THREAD_CHECKER 0

-#endif

+#define ENABLE_THREAD_CHECKER RTC_DCHECK_IS_ON

namespace rtc {

« no previous file with comments | « webrtc/base/thread_checker.h ('k') | webrtc/common_audio/resampler/push_resampler.cc » ('j') | no next file with comments »